subsurface

History

$K. \"pestophagous\" Heller$ K. \"pestophagous\" Heller e4c7c6e8eb Prevent gaschange tank icons from using garbage coords.

Tank icons were shown at incorrect spots on the profile
when the DiveEventItem object held a pointer to a struct
event even after the struct event at that address had
been freed.  When internalEvent is a pointer to freed
memory, internalEvent->time.seconds could have all kinds
of crazy values, which get used in member function
DiveEventItem::recalculatePos to place the tank at bad
x coordinates.

The DiveEventItem(s) no longer store a pointer to memory
that they do not own.  This way, no matter how the path of
execution arrives into slot recalculatePos, we never need
fear that the DiveEventItem will dereference a garbage
pointer to a struct event.

Fixes #968

Signed-off-by: K. Heller <pestophagous@gmail.com>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>

2015-12-06 09:37:07 -08:00

css

Fix TableWidget ( equipment ones ) on dark scheme.

2013-12-12 03:26:39 +01:00

marble

Resync included header with upstream

2014-01-15 15:49:50 +07:00

profile

Prevent gaschange tank icons from using garbage coords.

2015-12-06 09:37:07 -08:00

statistics

Address uninitialized member warnings

2015-06-22 10:57:51 -07:00

about.cpp

Re-assign numbers for beta versions

2015-09-03 07:40:14 -07:00

about.h

Headers cleanup.

2014-06-26 15:47:02 -07:00

about.ui

SubsurfaceAbout class cleanup.

2014-02-08 08:00:27 -08:00

btdeviceselectiondialog.cpp

Fix build error on Windows with Qt5.5

2015-09-20 15:08:14 -07:00

btdeviceselectiondialog.h

Fix build error on Windows with Qt5.5

2015-09-20 15:08:14 -07:00

btdeviceselectiondialog.ui

Style and readability tweaks to btdeviceselectiondialog

2015-09-05 07:08:20 -07:00

configuredivecomputerdialog.cpp

Fix building without BT support

2015-10-26 06:51:47 -07:00

configuredivecomputerdialog.h

Fix building without BT support

2015-10-26 06:51:47 -07:00

configuredivecomputerdialog.ui

Probe and expose OSTC3 model information

2015-09-25 09:56:11 -07:00

divecomponentselection.ui

Layout issues: Fix DiveShare export dialog

2015-05-25 17:45:13 -07:00

divecomputermanagementdialog.cpp

Fewer rebuilds triggered by changes in models.h

2015-05-29 14:13:44 -07:00

divecomputermanagementdialog.h

Massive automated whitespace cleanup

2014-02-27 20:09:57 -08:00

divecomputermanagementdialog.ui

divecomputermanagementdilog capitalisation consitency

2014-07-10 16:26:20 -07:00

divelistview.cpp

Undo/redo of dive deletion needs to handle trips as well

2015-10-02 14:50:12 -04:00

divelistview.h

Add support to "split" a dive with surface time in the middle

2015-10-01 22:29:43 -04:00

divelogexportdialog.cpp

More style and readability changes

2015-09-05 07:42:57 -07:00

filterwidget.ui

Add better icons for the filter dialog

2014-12-31 23:53:28 -08:00

globe.cpp

Don't zoom out the globe if the dive site has no GPS

2015-10-01 07:52:13 -04:00

globe.h

Enable building with NO_MARBLE again

2015-07-31 11:01:57 -07:00

graphicsview-common.cpp

CCR option: display o2 sensor data

2015-01-21 17:00:18 +12:00

graphicsview-common.h

CCR option: display o2 sensor data

2015-01-21 17:00:18 +12:00

groupedlineedit.cpp

Change colors of stars if widget has focus

2015-08-15 05:00:30 -07:00

groupedlineedit.h

Massive automated whitespace cleanup

2014-02-27 20:09:57 -08:00

kmessagewidget.cpp

KMessageWidget: hide messages regardless whether it's visible

2015-07-16 10:55:55 -07:00

kmessagewidget.h

Update KMessageWidget to KF5

2015-06-03 21:26:31 -07:00

listfilter.ui

Layout issues: Fix spacing for the filter dialog

2015-05-25 17:43:08 -07:00

locationinformation.cpp

Location completion matches on whole name

2015-12-06 09:35:19 -08:00

locationinformation.h

Remove unused member

2015-10-02 17:30:21 -04:00

locationInformation.ui

Add the labels for taxonomy in dive site widget

2015-10-08 06:17:40 +01:00

maintab.cpp

Statistics tab: clear min/max duration with just one dive selected

2015-12-06 09:28:06 -08:00

maintab.h

Remove unused code

2015-10-06 21:15:51 +01:00

maintab.ui

Add a new QLineEdit to set the dive trip location

2015-10-01 17:59:44 -04:00

mainwindow.cpp

Enable/Disable toolbar element in freedive mode

2015-10-18 17:37:49 -07:00

mainwindow.h

Enable/Disable toolbar element in freedive mode

2015-10-18 17:37:49 -07:00

mainwindow.ui

Make Facebook more user friendly

2015-09-16 21:16:58 -07:00

metrics.cpp

Unify icon metrics

2014-10-18 15:16:15 -07:00

metrics.h

Unify icon metrics

2014-10-18 15:16:15 -07:00

modeldelegates.cpp

modeldelegates.cpp: add custom highlight drawing in location items

2015-10-07 18:35:37 +01:00

modeldelegates.h

Create a delegate to display custom data

2015-07-01 19:24:52 -07:00

notificationwidget.cpp

Cloud storage: clear our last error if verification succeeds

2015-06-14 14:18:51 -07:00

notificationwidget.h

Cloud storage: clear our last error if verification succeeds

2015-06-14 14:18:51 -07:00

plannerDetails.ui

Layout issues: Fix planner layout

2015-05-25 17:45:13 -07:00

plannerSettings.ui

Planner: add recreational mode tooltip

2015-10-12 09:44:56 -07:00

preferences.cpp

Simplify code

2015-10-07 07:56:44 +01:00

preferences.h

Make password change asynchronous

2015-07-22 15:06:57 -07:00

preferences.ui

Passwords fields should have echoMode Password

2015-10-07 18:45:00 +01:00

printdialog.cpp

Printing: use the same code for both statistics and divelist print

2015-08-22 18:36:19 +03:00

printdialog.h

Printing: add template_options struct that contains template

2015-07-05 21:00:25 +03:00

printoptions.cpp

Print: copy the bundled templates to a safe location

2015-10-18 17:37:49 -07:00

printoptions.h

Printing: add statistics templates to the dialog

2015-08-22 18:34:34 +03:00

printoptions.ui

Printing: add "Import", "Export" and "Delete" buttons for templates

2015-07-28 11:37:51 +03:00

qtwaitingspinner.cpp

Add a new class, QtWaitingSpinner, MIT Licensed.

2015-05-17 15:00:25 -07:00

qtwaitingspinner.h

Add a new class, QtWaitingSpinner, MIT Licensed.

2015-05-17 15:00:25 -07:00

renumber.ui

Make some dialogs modal to MainWindow

2014-03-12 10:14:17 -07:00

searchbar.ui

Add a horizontal spacer to make the searchbar layout better

2014-07-11 17:00:23 -07:00

setpoint.ui

A widget to add a set-point change

2014-12-01 14:19:03 -08:00

shiftimagetimes.ui

Add checkbox to force images to match dives

2015-09-11 09:18:55 -07:00

shifttimes.ui

shiftimes capitalisation consitency and title

2014-07-11 07:05:17 -07:00

simplewidgets.cpp

When calculating the offset, both times are localtime

2015-10-22 07:04:32 +09:00

simplewidgets.h

Add checkbox to force images to match dives

2015-09-11 09:18:55 -07:00

socialnetworks.cpp

Make Facebook more user friendly

2015-09-16 21:16:58 -07:00

socialnetworks.h

Make Facebook more user friendly

2015-09-16 21:16:58 -07:00

socialnetworksdialog.ui

Facebook integration: improve dialog layout

2014-12-29 11:58:38 -08:00

starwidget.cpp

Minor code cleanup.

2015-08-15 05:01:33 -07:00

starwidget.h

Unify icon metrics

2014-10-18 15:16:15 -07:00

subsurfacewebservices.cpp

Allow building with both libzip 0.11.x and 1.0.x

2015-10-26 06:51:47 -07:00

subsurfacewebservices.h

Make password change asynchronous

2015-07-22 15:06:57 -07:00

tableview.cpp

Fewer rebuilds triggered by changes in models.h

2015-05-29 14:13:44 -07:00

tableview.h

TableView - improving the column width calculation

2015-03-19 15:33:16 -07:00

tableview.ui

Revert "Remove unused strings from ui files"

2014-12-24 10:06:41 -08:00

tagwidget.cpp

Remove information panel from mainwindow.ui

2015-02-10 10:45:45 -08:00

tagwidget.h

727 fixed

2014-11-17 06:02:21 +00:00

templateedit.cpp

Print: remove the warning about editing bundled templates

2015-10-18 17:37:49 -07:00

templateedit.h

Printing: fix TemplateEdit color selection bug

2015-08-15 15:02:04 +03:00

templateedit.ui

Style & spelling changes to printing

2015-09-05 07:43:11 -07:00

undocommands.cpp

Use copy_string() to avoid potential crash

2015-10-03 07:19:55 -04:00

undocommands.h

Undo/redo of dive deletion needs to handle trips as well

2015-10-02 14:50:12 -04:00

updatemanager.cpp

Remove unneeded includes

2015-08-31 15:12:18 -07:00

updatemanager.h

Add unique but random UUID to server queries

2015-01-25 12:02:13 -08:00

urldialog.ui

Allow images to be added via the web

2015-04-24 09:36:21 -07:00

usermanual.cpp

usermanual.cpp: use default QWidget theme colors for text selections

2015-10-13 08:18:51 -07:00

usermanual.h

Make search and close shortcut for user manual work on Mac

2015-01-28 14:30:19 -08:00

usersurvey.cpp

Move helper functions around

2015-02-23 09:31:08 -08:00

usersurvey.h

Move helper functions around

2015-02-23 09:31:08 -08:00

usersurvey.ui

Include iPhone companion app to user survey

2015-01-30 22:48:08 -08:00

webservices.ui

webservice capitalisation consitency

2014-07-11 07:05:38 -07:00