Don't zoom out the globe if the dive site has no GPS
This may or may not look intuitive, but it can cause problems with the zoom seemingly stuck all out (because of the timeouts). So instead stay where you are. If the current dive site has GPS then its flag will be bigger and brighter - so there still is visual feedback. But there's less crazy zooming around. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
parent
a52f8f8168
commit
efa4dc3c9a
@ -251,7 +251,8 @@ void GlobeGPS::reload()
|
||||
void GlobeGPS::centerOnDiveSite(struct dive_site *ds)
|
||||
{
|
||||
if (!dive_site_has_gps_location(ds)) {
|
||||
zoomOutForNoGPS();
|
||||
// this is not intuitive and at times causes trouble - let's comment it out for now
|
||||
// zoomOutForNoGPS();
|
||||
return;
|
||||
}
|
||||
qreal longitude = ds->longitude.udeg / 1000000.0;
|
||||
@ -328,8 +329,9 @@ void GlobeGPS::prepareForGetDiveCoordinates()
|
||||
messageWidget->setCloseButtonVisible(false);
|
||||
messageWidget->animatedShow();
|
||||
editingDiveLocation = true;
|
||||
if (!dive_has_gps_location(current_dive))
|
||||
zoomOutForNoGPS();
|
||||
// this is not intuitive and at times causes trouble - let's comment it out for now
|
||||
// if (!dive_has_gps_location(current_dive))
|
||||
// zoomOutForNoGPS();
|
||||
}
|
||||
|
||||
void GlobeGPS::changeDiveGeoPosition(qreal lon, qreal lat, GeoDataCoordinates::Unit unit)
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user