subsurface/CHANGELOG.md
Berthold Stoeger b0f1b25806 Crash fix: prevent crash in MapLocationModel::reload
Commit 0c387549164d7eec3ea6647c54ada2fba7f8d5e6 introduced a
bug in MapLocationModel::reload() by setting an entry in the
name-to-location map before the location was initialized.

Move the setting of the map entry back where it was before:
after the assignment of the location variable.

Moreover, define the location variable directly on allocation
of the location to avoid thus bugs in the future.

Why did we not get a "might be used unitialized" warning
anyway?

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2019-07-27 14:57:31 -07:00

236 B

  • fix crash when (re-)loading maps

  • Always add new entries at the very top of this file above other existing entries and this note.
  • Use this layout for new entries: [Area]: [Details about the change] [reference thread / issue]