FlapJackApps/subsurface
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
subsurface/core
History
Jan Mulder fed2c5b6a1 mobile cleanup: unduplicate code and do not loop over dives (1) 
This is the first of a set of commits that are (very) similar.
It appeared that a number of more or less static lists, which are
constructed by a loop over all dives in the logbook, were executed
when changing focus to a next dive. For example, the in this
commit addressed list of used dive suits.

What was wrong was that the suitList was linked to a dive. There
is only a need to construct the list of used suits when data is
changed (and obviously, once on startup of the app). Further, it
appeared that a lot of code was duplicated and that we can use
(in this case) the same code from the desktop completionmodels.cpp.

Basically, this commit involves the following changes:
- include completionmodels.cpp in mobile and desktop (so move
it from the desktop only category to the generic category).
- remove double code from DiveObjectHelper.cpp
- Do not differentiate in the init phase and the normal refresh
of the list
- the per dive logic is now only the getting of a previously
constructed list (in init or update of the divelist).

There are no visible changes in the UI, other than a better
performance when scrolling over dive details.

Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2018-01-31 14:48:14 +01:00
..
subsurface-qt
mobile cleanup: unduplicate code and do not loop over dives (1)
2018-01-31 14:48:14 +01:00
android.cpp
win32: optimize the console and logging logic
2017-11-03 07:49:11 -07:00
btdiscovery.cpp
Cleanup: avoid potentially uninitialized members
2017-12-27 17:24:12 -08:00
btdiscovery.h
mobile: enable switching BT on/off during session.
2017-10-12 09:43:40 +02:00
checkcloudconnection.cpp
Allocate CheckCloudConnection object on stack
2017-12-06 02:23:47 +01:00
checkcloudconnection.h
Remove self-include of core/checkcloudconnection.h
2017-12-06 02:23:47 +01:00
cloudstorage.cpp
Constify strings in pref.h
2017-11-18 21:57:33 +01:00
cloudstorage.h
Remove bogus member that hides global variable
2017-10-26 20:44:02 +02:00
CMakeLists.txt
Refactor CSV import
2018-01-08 06:06:12 +02:00
cochran.c
Start cleaning up sensor indexing for multiple sensors
2017-07-21 16:33:19 -07:00
cochran.h
Cochran import: better support for older models
2017-05-31 21:53:00 -07:00
color.cpp
Typo: indice -> index
2018-01-10 21:25:02 +01:00
color.h
Typo: indice -> index
2018-01-10 21:25:02 +01:00
compressibility.r
Move subsurface-core to core and qt-mobile to mobile-widgets
2016-04-04 22:33:58 -07:00
configuredivecomputer.cpp
Save Subsurface version to libdivecomputer logfile
2017-09-28 08:51:34 +02:00
configuredivecomputer.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
configuredivecomputerthreads.cpp
Fix typo: LENGHT -> LENGTH
2017-11-17 15:29:42 +01:00
configuredivecomputerthreads.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
connectionlistmodel.cpp
Do not add double ConnectionList items
2018-01-24 16:19:09 +01:00
connectionlistmodel.h
Add function to clear connectionModel data
2017-10-12 09:32:12 +02:00
datatrak.c
Cleanup: avoid memory leak
2017-12-27 17:14:43 -08:00
datatrak.h
Datatrak import rework: Add another memory size ckeck
2017-05-07 07:48:12 -07:00
deco.c
Prevent overflow in effective GF calculation
2017-12-25 19:47:45 +01:00
deco.h
Localize global planner state
2017-11-25 20:13:01 +01:00
device.c
Init every struct sample with default values
2017-11-13 20:50:10 -08:00
device.h
Add SPDX header to core C files
2017-04-29 13:32:55 -07:00
devicedetails.cpp
Implement OSTC4 specific settings
2017-05-04 10:50:15 -07:00
devicedetails.h
Implement OSTC4 specific settings
2017-05-04 10:50:15 -07:00
display.h
Display values in info box only if value is interesting
2017-11-13 20:50:10 -08:00
dive.c
Only give ICD warning if pN2 increases
2018-01-21 15:24:46 +01:00
dive.h
Make report_error() reentrant
2018-01-31 14:47:26 +01:00
divecomputer.cpp
Use helper function empty_string() instead of manual checks
2018-01-11 06:07:13 +01:00
divecomputer.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
divelist.c
Introduce helper function empty_string()
2018-01-11 06:07:13 +01:00
divelist.h
Unused code: remove trip_has_selected_dives()
2018-01-10 16:45:42 +01:00
divelogexportlogic.cpp
Creation of dive duration string and surface interval string
2017-05-26 15:50:52 -07:00
divelogexportlogic.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
divesite-helper.cpp
Cleanup: rename file to avoid confusion
2017-12-08 16:29:49 +01:00
divesite.c
Introduce helper function empty_string()
2018-01-11 06:07:13 +01:00
divesite.h
Tags for geo references: Nicer look, translations and warning message
2017-10-17 06:12:07 -04:00
divesitehelpers.cpp
Remove unused urls
2018-01-06 09:21:16 +01:00
divesitehelpers.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
downloadfromdcthread.cpp
Workaround for invalid bluetooth device names
2017-12-31 07:56:33 -08:00
downloadfromdcthread.h
Make Bluetooth naming consistent
2017-11-13 20:48:17 -08:00
equipment.c
Unused code: remove weightsystems_equal()
2018-01-10 16:45:42 +01:00
errorhelper.c
Make report_error() reentrant
2018-01-31 14:47:26 +01:00
exif.cpp
Image import: Make Exif handling more tolerant, better info,...
2017-05-06 08:07:16 -07:00
exif.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
file.c
Introduce helper function empty_string()
2018-01-11 06:07:13 +01:00
file.h
Make a few functions of static linkage
2018-01-08 09:52:55 +02:00
gas-model.c
Compute and display gas density
2017-05-26 15:52:04 -07:00
gaspressures.c
Cleanup: durations are now signed
2017-12-17 10:25:01 -08:00
gaspressures.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
gettext.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
gettextfromc.cpp
Remove superfluous QScopedPointer<>s in singletons
2017-12-24 11:04:10 -08:00
gettextfromc.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
git-access.c
Unify username handling of remote git repositories
2018-01-19 09:45:08 +02:00
git-access.h
Support non-https:// repositories for saving
2018-01-19 09:45:08 +02:00
gpslocation.cpp
GpsLocation::clearGpsData() is only used in SUBSURFACE_MOBILE
2018-01-10 16:45:42 +01:00
gpslocation.h
GpsLocation::clearGpsData() is only used in SUBSURFACE_MOBILE
2018-01-10 16:45:42 +01:00
helpers.h
Creation of dive duration string and surface interval string
2017-05-26 15:50:52 -07:00
imagedownloader.cpp
cleanup: Uninitialized scalar field
2017-12-29 09:14:20 -08:00
imagedownloader.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
import-cobalt.c
Move Cobalt DB import to its own file
2017-11-29 01:22:17 +01:00
import-csv.c
Move always true ++lineptr out of while-condition
2018-01-11 06:07:13 +01:00
import-csv.h
Make a few functions of static linkage
2018-01-08 09:52:55 +02:00
import-divinglog.c
Check different sensors on divinglog import
2017-12-27 20:45:24 +01:00
import-shearwater.c
Move Shearwater DB import into its own file
2017-11-29 01:22:17 +01:00
import-suunto.c
Cleanup: durations are now signed
2017-12-17 10:25:01 -08:00
isocialnetworkintegration.cpp
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
isocialnetworkintegration.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
libdivecomputer.c
Introduce helper function empty_string()
2018-01-11 06:07:13 +01:00
libdivecomputer.h
QML UI: add dev_info data to AppLog
2017-07-09 12:50:22 -07:00
linux.c
Use helper function empty_string() instead of manual checks
2018-01-11 06:07:13 +01:00
liquivision.c
cleanup: initilize local variable
2018-01-10 16:45:42 +01:00
load-git.c
Improve profile display in planner
2018-01-19 12:38:11 +02:00
macos.c
Introduce helper function empty_string()
2018-01-11 06:07:13 +01:00
membuffer.c
Fix crash when text empty
2017-10-08 19:41:54 +03:00
membuffer.h
Refactore parse-xml.c into parse.c and parse-xml.c
2017-11-27 13:42:10 -08:00
metrics.cpp
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
metrics.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
ostctools.c
cleanup: Unchecked return value from library
2017-12-29 09:14:20 -08:00
parse-xml.c
Improve profile display in planner
2018-01-19 12:38:11 +02:00
parse.c
Introduce helper function empty_string()
2018-01-11 06:07:13 +01:00
parse.h
Don't define cur_setting in header file
2018-01-05 00:29:20 +01:00
planner.c
Limit recreational dives to 6 hours
2018-01-26 07:04:45 +01:00
planner.h
Move planner notes to separate file
2017-05-26 15:44:36 -07:00
plannernotes.c
Planner: print icd information at 0.1 resolution
2018-01-24 22:03:42 +01:00
pluginmanager.cpp
Unused code: remove PluginManager::socialNetworkIntegrationPlugins()
2018-01-10 16:45:42 +01:00
pluginmanager.h
Unused code: remove PluginManager::socialNetworkIntegrationPlugins()
2018-01-10 16:45:42 +01:00
pref.h
Remove cloud_background_sync preferences option
2018-01-06 10:46:07 -08:00
prefs-macros.h
Fix ownership issues in preferences code
2017-11-25 07:41:09 -08:00
profile.c
Handle plot_info->nr <= 0 gracefully
2017-12-21 00:04:30 +01:00
profile.h
Hand planner variables to profile
2017-11-25 20:13:01 +01:00
qt-ble.cpp
Cleanup: Uninitialized scalar field
2017-12-28 17:30:25 +01:00
qt-ble.h
iOS build: need to more includes
2017-07-19 06:21:23 -07:00
qt-gui.h
Remove dead code
2017-11-19 12:20:43 -08:00
qt-init.cpp
Use different preference file for mobile
2018-01-19 09:39:07 +02:00
qthelper.cpp
Use helper function empty_string() instead of manual checks
2018-01-11 06:07:13 +01:00
qthelper.h
code cleanup: translators are not global
2018-01-18 17:36:31 +02:00
qthelperfromc.h
Remove function isCloudUrl()
2017-12-14 17:01:05 +01:00
qtserialbluetooth.cpp
Fix typo: successfull -> successful and succesfully -> successfully
2017-11-20 10:01:15 +01:00
save-git.c
Improve profile display in planner
2018-01-19 12:38:11 +02:00
save-html.c
Unify sample pressure and o2pressure as pressure[2] array
2017-07-20 17:32:54 -07:00
save-html.h
Add SPDX header to core C files
2017-04-29 13:32:55 -07:00
save-xml.c
Improve profile display in planner
2018-01-19 12:38:11 +02:00
serial_ftdi.c
Update to the latest libdc version
2017-12-12 21:16:19 -08:00
sha1.c
Move subsurface-core to core and qt-mobile to mobile-widgets
2016-04-04 22:33:58 -07:00
sha1.h
Move subsurface-core to core and qt-mobile to mobile-widgets
2016-04-04 22:33:58 -07:00
statistics.c
Cleanup: durations are now signed
2017-12-17 10:25:01 -08:00
statistics.h
Creation of dive duration string and surface interval string
2017-05-26 15:50:52 -07:00
strndup.h
Add SPDX header to core C files
2017-04-29 13:32:55 -07:00
strtod.c
Add SPDX header to core C files
2017-04-29 13:32:55 -07:00
subsurfacestartup.c
Introduce helper function empty_string()
2018-01-11 06:07:13 +01:00
subsurfacestartup.h
Fix ownership issues in preferences code
2017-11-25 07:41:09 -08:00
subsurfacesysinfo.cpp
Random whitespace cleanup
2017-05-27 11:07:20 -07:00
subsurfacesysinfo.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
taxonomy.c
Fix two bugs in taxonomy_set_country
2017-10-07 08:16:53 -07:00
taxonomy.h
Add taxonomy helper functions
2017-10-04 08:05:09 -07:00
time.c
Add SPDX header to core C files
2017-04-29 13:32:55 -07:00
uemis-downloader.c
uemis: code refactoring
2018-01-31 14:47:47 +01:00
uemis.c
cleanup: fix possbile buffer overrun
2018-01-10 16:45:42 +01:00
uemis.h
Add SPDX header to core C files
2017-04-29 13:32:55 -07:00
units.h
Change prefs.show_units_table to bool
2017-11-24 07:56:10 -08:00
version.c
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
version.h
Move subsurface-core to core and qt-mobile to mobile-widgets
2016-04-04 22:33:58 -07:00
webservice.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
windows.c
Clean up system_default_filename()
2017-11-22 19:22:29 +01:00
windowtitleupdate.cpp
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
windowtitleupdate.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
worldmap-options.h
Add SPDX header to core C files
2017-04-29 13:32:55 -07:00
worldmap-save.c
worldmap-save: don't use an API key
2017-07-30 16:28:30 -07:00
worldmap-save.h
Add SPDX header to core C files
2017-04-29 13:32:55 -07:00