FlapJackApps/subsurface
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
subsurface/desktop-widgets
History
Lubomir I. Ivanov 769aca9e95 equipment: sanitize 'tank_info' loop limits 
In a number of places the global 'tank_info' array
is being iterated based on a 'tank_info[idx].name != NULL'
condition.

This is dangerous because if the user has added a lot of tanks,
such loops can reach 'tank_info[MAX_TANK_INFO]'. This is an
out of bounds read and if the 'name' pointer there happens to be
non-NULL, passing that address to a peace of code that tries
to read it (like strlen()) would either SIGSEGV or have undefined
behavior.

Clamp all loops that iterate 'tank_info' to MAX_TANK_INFO.

Signed-off-by: Lubomir I. Ivanov <neolit123@gmail.com>
2018-06-20 09:30:58 +09:00
..
css
Move qt-ui to desktop-widgets
2015-10-30 10:36:49 -07:00
plugins
Cleanup: fold core/helpers.h into core/qthelper.h
2018-06-04 08:50:10 -07:00
preferences
equipment: sanitize 'tank_info' loop limits
2018-06-20 09:30:58 +09:00
statistics
desktop-widgets/statistics: Change Q_UNUSED to no parameter name
2018-05-21 12:48:04 -07:00
tab-widgets
Change from gettextFromC::instance()->tr() to gettextFromC::tr();
2018-06-18 07:42:39 +02:00
about.cpp
Get ready for 2018
2017-12-30 08:23:22 -08:00
about.h
Add SPDX header to desktop widgets
2017-04-29 13:32:55 -07:00
about.ui
Use icons relative path.
2017-11-30 23:14:46 -08:00
btdeviceselectiondialog.cpp
Cleanup: Use QString as parameter for [get|save]BtDeviceInfo()
2018-02-26 08:52:34 +01:00
btdeviceselectiondialog.h
cleanup: remove unused include
2017-12-23 11:17:47 +01:00
btdeviceselectiondialog.ui
Introduce mode field in Bluetooth device selection dialog
2017-11-16 14:26:51 +01:00
CMakeLists.txt
map-widget: move the widget and its resources to 'map-widget'
2017-11-05 14:48:56 -08:00
configuredivecomputerdialog.cpp
Cleanup: fold core/helpers.h into core/qthelper.h
2018-06-04 08:50:10 -07:00
configuredivecomputerdialog.h
Remove old duplicated code
2017-06-21 18:43:15 -07:00
configuredivecomputerdialog.ui
Configure ostc3: Remove obsoleted setting
2018-04-27 21:33:47 +03:00
divecomponentselection.ui
Use icons relative path.
2017-11-30 23:14:46 -08:00
divecomputermanagementdialog.cpp
Dive computers: turn QMultiMap into sorted vector
2018-06-17 06:53:13 +09:00
divecomputermanagementdialog.h
Cleanup: fold DiveComputerManagementDialog::update() into init()
2018-06-17 06:53:13 +09:00
divecomputermanagementdialog.ui
Use icons relative path.
2017-11-30 23:14:46 -08:00
divelistview.cpp
Cleanup: fold core/helpers.h into core/qthelper.h
2018-06-04 08:50:10 -07:00
divelistview.h
Cleanup: make lastUsedDir() functions static and non-slot, respectively
2018-06-09 17:11:29 +02:00
divelogexportdialog.cpp
desktop-widgets: Change Q_UNUSED to no parameter name
2018-05-21 12:48:04 -07:00
divelogexportdialog.h
Cleanup: fold core/helpers.h into core/qthelper.h
2018-06-04 08:50:10 -07:00
divelogexportdialog.ui
Use icons relative path.
2017-11-30 23:14:46 -08:00
divelogimportdialog.cpp
desktop-widgets: Change Q_UNUSED to no parameter name
2018-05-21 12:48:04 -07:00
divelogimportdialog.h
Add SPDX header to desktop widgets
2017-04-29 13:32:55 -07:00
divelogimportdialog.ui
Use icons relative path.
2017-11-30 23:14:46 -08:00
divepicturewidget.cpp
Implement different zoom levels for dive photos tab
2017-12-18 12:07:10 -08:00
divepicturewidget.h
Implement different zoom levels for dive photos tab
2017-12-18 12:07:10 -08:00
diveplanner.cpp
Change from gettextFromC::instance()->tr() to gettextFromC::tr();
2018-06-18 07:42:39 +02:00
diveplanner.h
Core: remove dive.h from files that don't need it
2018-05-14 10:13:39 -07:00
diveplanner.ui
Choose water presets from a qcombobox in planner, custom value possible
2018-03-02 08:38:22 -08:00
diveshareexportdialog.cpp
Cleanup: Don't clear WA_QuitOnClose attribute on dialogs
2018-06-16 04:02:47 -07:00
diveshareexportdialog.h
Random whitespace cleanup
2017-05-27 11:07:20 -07:00
diveshareexportdialog.ui
Move qt-ui to desktop-widgets
2015-10-30 10:36:49 -07:00
downloadfromdivecomputer.cpp
Cleanup: fold core/helpers.h into core/qthelper.h
2018-06-04 08:50:10 -07:00
downloadfromdivecomputer.h
Fix memory leak in download-from-dive-computer widget
2017-11-11 21:01:42 +01:00
downloadfromdivecomputer.ui
Use icons relative path.
2017-11-30 23:14:46 -08:00
filterwidget.ui
Use better aliases for icons.
2017-11-30 23:14:46 -08:00
groupedlineedit.cpp
Unused code: GroupedLineEdit::removeAllColors()
2018-01-10 16:45:42 +01:00
groupedlineedit.h
Unused code: GroupedLineEdit::removeAllColors()
2018-01-10 16:45:42 +01:00
kmessagewidget.cpp
Add SPDX header to desktop widgets
2017-04-29 13:32:55 -07:00
kmessagewidget.h
Add SPDX header to desktop widgets
2017-04-29 13:32:55 -07:00
listfilter.ui
Add tool tip for negate filter button
2017-12-30 08:15:11 -08:00
locationinformation.cpp
desktop-widgets: Change Q_UNUSED to no parameter name
2018-05-21 12:48:04 -07:00
locationinformation.h
locationinformation: don't update map location on typing
2017-11-27 22:59:22 +01:00
locationInformation.ui
Use correct alias for satellite icon for revers geo lookup
2018-01-27 12:29:00 -08:00
mainwindow.cpp
Dive computers: turn QMultiMap into sorted vector
2018-06-17 06:53:13 +09:00
mainwindow.h
Cleanup: make lastUsedDir() functions static and non-slot, respectively
2018-06-09 17:11:29 +02:00
mainwindow.ui
Turn take-cloud-online menu action into checkbox
2018-01-06 10:46:07 -08:00
mapwidget.cpp
Core: remove dive.h from files that don't need it
2018-05-14 10:13:39 -07:00
mapwidget.h
map-widget: allow real-time updates of edited markers
2017-11-09 12:40:25 -08:00
modeldelegates.cpp
desktop-widgets: Change Q_UNUSED to no parameter name
2018-05-21 12:48:04 -07:00
modeldelegates.h
Planner: Add combo box for dive mode selection
2018-05-14 23:47:00 +03:00
notificationwidget.cpp
Use queued connection to thread-safe MainWindow error handling
2018-01-31 14:47:26 +01:00
notificationwidget.h
Use queued connection to thread-safe MainWindow error handling
2018-01-31 14:47:26 +01:00
plannerDetails.ui
Bring back style sheet HTML for planner output
2017-02-24 01:06:09 -08:00
plannerSettings.ui
Planner and profile limit minimum GFlow to 10 and minimum GFhigh to 40
2017-11-13 11:53:55 +01:00
printdialog.cpp
desktop-widgets: Change Q_UNUSED to no parameter name
2018-05-21 12:48:04 -07:00
printdialog.h
Add SPDX header to desktop widgets
2017-04-29 13:32:55 -07:00
printer.cpp
Cleanup: fold core/helpers.h into core/qthelper.h
2018-06-04 08:50:10 -07:00
printer.h
Add SPDX header to desktop widgets
2017-04-29 13:32:55 -07:00
printoptions.cpp
Cleanup: fold core/helpers.h into core/qthelper.h
2018-06-04 08:50:10 -07:00
printoptions.h
cleanup: Uninitialized pointer field
2017-12-29 09:14:20 -08:00
printoptions.ui
Move qt-ui to desktop-widgets
2015-10-30 10:36:49 -07:00
qtwaitingspinner.cpp
Move qt-ui to desktop-widgets
2015-10-30 10:36:49 -07:00
qtwaitingspinner.h
Move qt-ui to desktop-widgets
2015-10-30 10:36:49 -07:00
renumber.ui
Use icons relative path.
2017-11-30 23:14:46 -08:00
searchbar.ui
Use better aliases for icons.
2017-11-30 23:14:46 -08:00
setpoint.ui
Use icons relative path.
2017-11-30 23:14:46 -08:00
shiftimagetimes.ui
Use icons relative path.
2017-11-30 23:14:46 -08:00
shifttimes.ui
Use icons relative path.
2017-11-30 23:14:46 -08:00
simplewidgets.cpp
In dive picture shift time dialog suppress double triggering of timeEdit
2018-06-18 15:08:27 +09:00
simplewidgets.h
Turn filter list options into context menu
2017-12-26 13:08:49 -08:00
starwidget.cpp
desktop-widgets: Change Q_UNUSED to no parameter name
2018-05-21 12:48:04 -07:00
starwidget.h
Add SPDX header to desktop widgets
2017-04-29 13:32:55 -07:00
subsurfacewebservices.cpp
Cleanup: Don't clear WA_QuitOnClose attribute on dialogs
2018-06-16 04:02:47 -07:00
subsurfacewebservices.h
Remove redundant declaration of set_userid()
2017-11-26 23:17:23 +01:00
tableview.cpp
Use better aliases for icons.
2017-11-30 23:14:46 -08:00
tableview.h
Add SPDX header to desktop widgets
2017-04-29 13:32:55 -07:00
tableview.ui
Move qt-ui to desktop-widgets
2015-10-30 10:36:49 -07:00
tagwidget.cpp
Show all autocompletes after entry of comma in tag list
2017-11-17 09:19:03 +01:00
tagwidget.h
Add SPDX header to desktop widgets
2017-04-29 13:32:55 -07:00
templateedit.cpp
Fix includes for building against Qt-5.11.0
2018-05-23 13:29:37 +03:00
templateedit.h
Add SPDX header to desktop widgets
2017-04-29 13:32:55 -07:00
templateedit.ui
templateedit.ui: give the layout for "Border width" unique name
2017-03-12 09:19:03 -07:00
templatelayout.cpp
Cleanup: fold core/helpers.h into core/qthelper.h
2018-06-04 08:50:10 -07:00
templatelayout.h
Cleanup: fold core/helpers.h into core/qthelper.h
2018-06-04 08:50:10 -07:00
undocommands.cpp
Core: introduce new subsurface-string header
2018-05-14 10:13:39 -07:00
undocommands.h
Core: remove dive.h from files that don't need it
2018-05-14 10:13:39 -07:00
updatemanager.cpp
Cleanup: fold core/helpers.h into core/qthelper.h
2018-06-04 08:50:10 -07:00
updatemanager.h
Add SPDX header to desktop widgets
2017-04-29 13:32:55 -07:00
urldialog.ui
Make the URL dialog contain QLineEdit
2017-01-12 14:06:54 -08:00
usermanual.cpp
Cleanup: fold core/helpers.h into core/qthelper.h
2018-06-04 08:50:10 -07:00
usermanual.h
Desktop: Derive UserManual from QDialog
2018-05-31 21:29:29 +03:00
usersurvey.cpp
Cleanup: fold core/helpers.h into core/qthelper.h
2018-06-04 08:50:10 -07:00
usersurvey.h
Add SPDX header to desktop widgets
2017-04-29 13:32:55 -07:00
usersurvey.ui
fix: User survey UI.
2017-03-06 06:40:00 -08:00
webservices.ui
Use icons relative path.
2017-11-30 23:14:46 -08:00