Some remote dive sites have no populated places (towns, cities) nearby. For such sites, we now fall back to looking up unpopulated place names, such as the reef or island name. Also some code refactorisation: the actual network access is now encapsulated in its own function removing some duplicated code handling in the reverseGeoLookup function and making it more readable. Furthermore, reverseGeoLookup() was completely refactored as most of its functionality was due to legacy requirements; the current code-base only calls this function from a single location and only with an empty taxonomy_data object. This makes the function more focussed and much simpler and more readable. Finally, a resource leak in reverseGeocde introduced in 4f3b26f9b6296273e37ec317bc68f32f94f546dc was fixed. Signed-off-by: Michael Werle <micha@michaelwerle.com>
141 lines
5.8 KiB
C++
141 lines
5.8 KiB
C++
// SPDX-License-Identifier: GPL-2.0
|
|
//
|
|
// infrastructure to deal with dive sites
|
|
//
|
|
|
|
#include "divesitehelpers.h"
|
|
|
|
#include "divesite.h"
|
|
#include "errorhelper.h"
|
|
#include "subsurface-string.h"
|
|
#include "qthelper.h"
|
|
#include "membuffer.h"
|
|
#include <QDebug>
|
|
#include <QJsonDocument>
|
|
#include <QJsonArray>
|
|
#include <QJsonObject>
|
|
#include <QNetworkReply>
|
|
#include <QNetworkRequest>
|
|
#include <QNetworkAccessManager>
|
|
#include <QUrlQuery>
|
|
#include <QEventLoop>
|
|
#include <QTimer>
|
|
#include <memory>
|
|
|
|
/** Performs a REST get request to a service returning a JSON object. */
|
|
static QJsonObject doAsyncRESTGetRequest(const QString& url, int msTimeout)
|
|
{
|
|
// By making the QNetworkAccessManager static and local to this function,
|
|
// only one manager exists for all geo-lookups and it is only initialized
|
|
// on first call to this function.
|
|
static QNetworkAccessManager rgl;
|
|
QNetworkRequest request;
|
|
QEventLoop loop;
|
|
QTimer timer;
|
|
|
|
request.setRawHeader("Accept", "text/json");
|
|
request.setRawHeader("User-Agent", getUserAgent().toUtf8());
|
|
QObject::connect(&timer, SIGNAL(timeout()), &loop, SLOT(quit()));
|
|
|
|
request.setUrl(url);
|
|
|
|
// By using a std::unique_ptr<>, we can exit from the function at any point
|
|
// and the reply will be freed. Likewise, when overwriting the pointer with
|
|
// a new value. According to Qt's documentation it is fine the delete the
|
|
// reply as long as we're not in a slot connected to error() or finish().
|
|
std::unique_ptr<QNetworkReply> reply(rgl.get(request));
|
|
timer.setSingleShot(true);
|
|
QObject::connect(&*reply, SIGNAL(finished()), &loop, SLOT(quit()));
|
|
timer.start(msTimeout);
|
|
loop.exec();
|
|
|
|
if (!timer.isActive()) {
|
|
report_error("timeout accessing %s", qPrintable(url));
|
|
QObject::disconnect(&*reply, SIGNAL(finished()), &loop, SLOT(quit()));
|
|
reply->abort();
|
|
return QJsonObject{};
|
|
}
|
|
|
|
timer.stop();
|
|
if (reply->error() > 0) {
|
|
report_error("got error accessing %s: %s", qPrintable(url), qPrintable(reply->errorString()));
|
|
return QJsonObject{};
|
|
}
|
|
int v = reply->attribute(QNetworkRequest::HttpStatusCodeAttribute).toInt();
|
|
if (v < 200 || v >= 300) {
|
|
return QJsonObject{};
|
|
}
|
|
QByteArray fullReply = reply->readAll();
|
|
QJsonParseError errorObject;
|
|
QJsonDocument jsonDoc = QJsonDocument::fromJson(fullReply, &errorObject);
|
|
if (errorObject.error != QJsonParseError::NoError) {
|
|
report_error("error parsing JSON response: %s", qPrintable(errorObject.errorString()));
|
|
return QJsonObject{};
|
|
}
|
|
// Success, return JSON response from server
|
|
return jsonDoc.object();
|
|
}
|
|
|
|
/// Performs a reverse-geo-lookup of the coordinates and returns the taxonomy data.
|
|
taxonomy_data reverseGeoLookup(degrees_t latitude, degrees_t longitude)
|
|
{
|
|
const QString geonamesNearbyURL = QStringLiteral("http://api.geonames.org/findNearbyJSON?lang=%1&lat=%2&lng=%3&radius=50&username=dirkhh");
|
|
const QString geonamesNearbyPlaceNameURL = QStringLiteral("http://api.geonames.org/findNearbyPlaceNameJSON?lang=%1&lat=%2&lng=%3&radius=50&username=dirkhh");
|
|
const QString geonamesOceanURL = QStringLiteral("http://api.geonames.org/oceanJSON?lang=%1&lat=%2&lng=%3&radius=50&username=dirkhh");
|
|
|
|
QString url;
|
|
QJsonObject obj;
|
|
taxonomy_data taxonomy = { 0, alloc_taxonomy() };
|
|
|
|
// check the oceans API to figure out the body of water
|
|
url = geonamesOceanURL.arg(getUiLanguage().section(QRegExp("[-_ ]"), 0, 0)).arg(latitude.udeg / 1000000.0).arg(longitude.udeg / 1000000.0);
|
|
obj = doAsyncRESTGetRequest(url, 5000); // 5 secs. timeout
|
|
QVariantMap oceanName = obj.value("ocean").toVariant().toMap();
|
|
if (oceanName["name"].isValid()) {
|
|
taxonomy.category[0].category = TC_OCEAN;
|
|
taxonomy.category[0].origin = taxonomy_origin::GEOCODED;
|
|
taxonomy.category[0].value = copy_qstring(oceanName["name"].toString());
|
|
taxonomy.nr = 1;
|
|
}
|
|
|
|
// check the findNearbyPlaces API from geonames - that should give us country, state, city
|
|
url = geonamesNearbyPlaceNameURL.arg(getUiLanguage().section(QRegExp("[-_ ]"), 0, 0)).arg(latitude.udeg / 1000000.0).arg(longitude.udeg / 1000000.0);
|
|
obj = doAsyncRESTGetRequest(url, 5000); // 5 secs. timeout
|
|
QVariantList geoNames = obj.value("geonames").toVariant().toList();
|
|
if (geoNames.count() == 0) {
|
|
// check the findNearby API from geonames if the previous search came up empty - that should give us country, state, location
|
|
url = geonamesNearbyURL.arg(getUiLanguage().section(QRegExp("[-_ ]"), 0, 0)).arg(latitude.udeg / 1000000.0).arg(longitude.udeg / 1000000.0);
|
|
obj = doAsyncRESTGetRequest(url, 5000); // 5 secs. timeout
|
|
geoNames = obj.value("geonames").toVariant().toList();
|
|
}
|
|
if (geoNames.count() > 0) {
|
|
QVariantMap firstData = geoNames.at(0).toMap();
|
|
|
|
// fill out all the data - start at COUNTRY since we already got OCEAN above
|
|
for (int idx = TC_COUNTRY; idx < TC_NR_CATEGORIES; idx++) {
|
|
if (firstData[taxonomy_api_names[idx]].isValid()) {
|
|
taxonomy.category[taxonomy.nr].category = idx;
|
|
taxonomy.category[taxonomy.nr].origin = taxonomy_origin::GEOCODED;
|
|
taxonomy.category[taxonomy.nr].value = copy_qstring(firstData[taxonomy_api_names[idx]].toString());
|
|
taxonomy.nr++;
|
|
}
|
|
}
|
|
int l3 = taxonomy_index_for_category(&taxonomy, TC_ADMIN_L3);
|
|
int lt = taxonomy_index_for_category(&taxonomy, TC_LOCALNAME);
|
|
if (l3 == -1 && lt != -1) {
|
|
// basically this means we did get a local name (what we call town), but just like most places
|
|
// we didn't get an adminName_3 - which in some regions is the actual city that town belongs to,
|
|
// then we copy the town into the city
|
|
taxonomy.category[taxonomy.nr].category = TC_ADMIN_L3;
|
|
taxonomy.category[taxonomy.nr].origin = taxonomy_origin::GEOCOPIED;
|
|
taxonomy.category[taxonomy.nr].value = copy_string(taxonomy.category[lt].value);
|
|
taxonomy.nr++;
|
|
}
|
|
} else {
|
|
report_error("geonames.org did not provide reverse lookup information");
|
|
//qDebug() << "no reverse geo lookup; geonames returned\n" << fullReply;
|
|
}
|
|
|
|
return taxonomy;
|
|
}
|