FlapJackApps/subsurface
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
subsurface/core
History
Berthold Stoeger 360f07e453 Cleanup: pass gasmix by value 
In a previous commit, the get_gasmix_* functions were changed to
return by value. For consistency, also pass gasmix by value.

Note that on common 64-bit platforms struct gasmix is the size
of a pointer [2 * 32 bit vs. 64 bit] and therefore uses the
same space on the stack. On 32-bit platforms, the stack use
is probably doubled, but in return a dereference is avoided.

Supporting arbitrary gas-mixes (H2, Ar, ...) will be such an
invasive change that going back to pointers is probably the
least of our worries.

This commit is a step in const-ifying input parameters (passing
by value is the ultimate way of signaling that the input parameter
will not be changed [unless there are references to said parameter]).

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2018-08-23 05:16:38 -07:00
..
settings
core: qPref limit header includes
2018-08-15 16:11:39 -07:00
subsurface-qt
Cleanup: pass gasmix by value
2018-08-23 05:16:38 -07:00
android.cpp
Whitespace cleanup, extra braces, and null checks
2018-08-11 11:14:22 -07:00
btdiscovery.cpp
Correctly recognize more OSTC variants as BLE
2018-07-02 09:24:30 -07:00
btdiscovery.h
Cleanup: Use QString as parameter for [get|save]BtDeviceInfo()
2018-02-26 08:52:34 +01:00
checkcloudconnection.cpp
Cleanup: fold core/helpers.h into core/qthelper.h
2018-06-04 08:50:10 -07:00
checkcloudconnection.h
Remove self-include of core/checkcloudconnection.h
2017-12-06 02:23:47 +01:00
cloudstorage.cpp
core: activate qPrefCloudStorage
2018-07-21 07:49:25 -07:00
cloudstorage.h
Remove bogus member that hides global variable
2017-10-26 20:44:02 +02:00
CMakeLists.txt
core: remove SettingsObjectWrapper.*
2018-08-15 16:11:39 -07:00
cochran.c
core: replace (void) with UNUSED(x) and include ssrf.h
2018-05-24 08:34:14 -07:00
cochran.h
Cochran import: better support for older models
2017-05-31 21:53:00 -07:00
color.cpp
Cleanups to core/color.[c|hpp]
2018-07-18 02:09:15 +03:00
color.h
Cleanups to core/color.[c|hpp]
2018-07-18 02:09:15 +03:00
compressibility.r
Move subsurface-core to core and qt-mobile to mobile-widgets
2016-04-04 22:33:58 -07:00
configuredivecomputer.cpp
Actually tie in the new libdivecomputer IO model to open the dive computer device
2018-04-24 17:54:08 -07:00
configuredivecomputer.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
configuredivecomputerthreads.cpp
core: Change Q_UNUSED to no parameter name
2018-05-21 12:48:04 -07:00
configuredivecomputerthreads.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
connectionlistmodel.cpp
core: add indexOf member to ConnectionListModel
2018-08-11 11:14:22 -07:00
connectionlistmodel.h
core: add indexOf member to ConnectionListModel
2018-08-11 11:14:22 -07:00
datatrak.c
Core: remove dive.h from files that don't need it
2018-05-14 10:13:39 -07:00
datatrak.h
Datatrak import rework: Add another memory size ckeck
2017-05-07 07:48:12 -07:00
deco.c
Cleanup: pass gasmix by value
2018-08-23 05:16:38 -07:00
deco.h
Localize global planner state
2017-11-25 20:13:01 +01:00
device.c
core: replace (void) with UNUSED(x) and include ssrf.h
2018-05-24 08:34:14 -07:00
device.h
Core: remove dive.h from files that don't need it
2018-05-14 10:13:39 -07:00
devicedetails.cpp
Implement OSTC4 specific settings
2017-05-04 10:50:15 -07:00
devicedetails.h
Implement OSTC4 specific settings
2017-05-04 10:50:15 -07:00
display.h
Display values in info box only if value is interesting
2017-11-13 20:50:10 -08:00
dive.c
Cleanup: pass gasmix by value
2018-08-23 05:16:38 -07:00
dive.h
Cleanup: pass gasmix by value
2018-08-23 05:16:38 -07:00
divecomputer.cpp
core: remove SettingsObjectWrapper and update qPref calls
2018-08-15 16:11:39 -07:00
divecomputer.h
Dive computers: turn QMultiMap into sorted vector
2018-06-17 06:53:13 +09:00
divelist.c
Cleanup: pass gasmix by value
2018-08-23 05:16:38 -07:00
divelist.h
Cleanup: removed unused functions in divelist.h
2018-07-18 09:04:47 -07:00
divelogexportlogic.cpp
divelogexportlogic: show warning on missing 'theme' folder
2018-08-17 00:58:01 +02:00
divelogexportlogic.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
divesite-helper.cpp
Translations: unify gettextFromC::tr() and QObject::tr()
2018-07-04 05:33:31 +08:00
divesite.c
core: remove clang warning in divesite.c
2018-07-11 12:59:33 +02:00
divesite.h
Tags for geo references: Nicer look, translations and warning message
2017-10-17 06:12:07 -04:00
divesitehelpers.cpp
Cleanup: fold core/helpers.h into core/qthelper.h
2018-06-04 08:50:10 -07:00
divesitehelpers.h
Cleanup: remove all override modifiers
2018-08-01 06:30:00 -07:00
downloadfromdcthread.cpp
core: remove SettingsObjectWrapper and update qPref calls
2018-08-15 16:11:39 -07:00
downloadfromdcthread.h
Cleanup: remove all override modifiers
2018-08-01 06:30:00 -07:00
equipment.c
Cleanup: pass gasmix by value
2018-08-23 05:16:38 -07:00
errorhelper.c
Make report_error() reentrant
2018-01-31 14:47:26 +01:00
exif.cpp
Coding-style: remove superfluous parentheses
2018-02-17 19:38:52 -08:00
exif.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
file.c
Cleanup: fix memory leak on failed DLF import
2018-08-23 05:07:58 -07:00
file.h
Make a few functions of static linkage
2018-01-08 09:52:55 +02:00
format.cpp
Cleanup: Slightly shorten code in vqasprintf_loc()
2018-04-09 11:29:43 -07:00
format.h
Cleanup: Move *_loc formatting functions into new format.cpp file
2018-04-09 11:29:43 -07:00
gas-model.c
Cleanup: pass gasmix by value
2018-08-23 05:16:38 -07:00
gaspressures.c
Provide correct cylinder pressures for bailout dives
2018-06-08 17:07:20 +03:00
gaspressures.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
gettext.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
gettextfromc.cpp
Localization: make cache thread safe and robust against use-after-free
2018-06-24 20:31:14 +02:00
gettextfromc.h
Localization: remove gettextFromC::instance()
2018-06-24 20:31:14 +02:00
git-access.c
core: replace (void) with UNUSED(x) and include ssrf.h
2018-05-24 08:34:14 -07:00
git-access.h
Support non-https:// repositories for saving
2018-01-19 09:45:08 +02:00
gpslocation.cpp
Cleanup: fold core/helpers.h into core/qthelper.h
2018-06-04 08:50:10 -07:00
gpslocation.h
Translations: unify gettextFromC::tr() and QObject::tr()
2018-07-04 05:33:31 +08:00
imagedownloader.cpp
Dive media: Extract thumbnails from videos with ffmpeg
2018-07-28 15:31:25 -07:00
imagedownloader.h
Dive media: Extract thumbnails from videos with ffmpeg
2018-07-28 15:31:25 -07:00
import-cobalt.c
core: replace (void) with UNUSED(x) and include ssrf.h
2018-05-24 08:34:14 -07:00
import-csv.c
Core: introduce new subsurface-string header
2018-05-14 10:13:39 -07:00
import-csv.h
Make a few functions of static linkage
2018-01-08 09:52:55 +02:00
import-divinglog.c
Cleanup: pass gasmix by value
2018-08-23 05:16:38 -07:00
import-shearwater.c
Remove unnecessary {}
2018-05-27 23:18:01 +03:00
import-suunto.c
DM5 import: support for larger sample size
2018-06-15 17:45:33 -07:00
ios.cpp
core: Change Q_UNUSED to no parameter name
2018-05-21 12:48:04 -07:00
isocialnetworkintegration.cpp
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
isocialnetworkintegration.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
libdivecomputer.c
FTDI support: try ftdi_open first if the device name is 'ftdi'
2018-06-21 16:16:29 +09:00
libdivecomputer.h
Create one function to determine the supported transports
2018-04-27 11:52:48 -07:00
liquivision.c
core: replace (void) with UNUSED(x) and include ssrf.h
2018-05-24 08:34:14 -07:00
load-git.c
git storage: avoid warning about "Unmatched action 'hash'"
2018-07-07 07:35:45 -07:00
macos.c
core: replace (void) with UNUSED(x) and include ssrf.h
2018-05-24 08:34:14 -07:00
membuffer.c
Localization: Make Qt's locale-aware formatting accessible from C
2018-03-05 16:23:55 +01:00
membuffer.h
Add usage documentation for membuffer helper functions
2018-04-10 08:18:32 -07:00
metadata.cpp
Cleanup: remove silly " != 0" expression
2018-08-01 15:30:54 +03:00
metadata.h
Metadata: extract duration fom QuickTime/MP4-style containers
2018-07-14 08:32:30 +02:00
metrics.cpp
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
metrics.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
ostctools.c
Core: introduce new subsurface-string header
2018-05-14 10:13:39 -07:00
parse-xml.c
Cleanup: pass gasmix by value
2018-08-23 05:16:38 -07:00
parse.c
core: replace (void) with UNUSED(x) and include ssrf.h
2018-05-24 08:34:14 -07:00
parse.h
Don't define cur_setting in header file
2018-01-05 00:29:20 +01:00
planner.c
Cleanup: pass gasmix by value
2018-08-23 05:16:38 -07:00
planner.h
Cleanup: pass gasmix by value
2018-08-23 05:16:38 -07:00
plannernotes.c
Cleanup: pass gasmix by value
2018-08-23 05:16:38 -07:00
pluginmanager.cpp
Unused code: remove PluginManager::socialNetworkIntegrationPlugins()
2018-01-10 16:45:42 +01:00
pluginmanager.h
Unused code: remove PluginManager::socialNetworkIntegrationPlugins()
2018-01-10 16:45:42 +01:00
pref.h
core: change default_file_behavior from short to enum
2018-08-14 09:09:06 -07:00
prefs-macros.h
core: make prefs-macros compile safe.
2018-06-15 14:11:57 -07:00
profile.c
Cleanup: pass gasmix by value
2018-08-23 05:16:38 -07:00
profile.h
Plot OC-pO2 graph for SCR dives
2018-04-28 20:11:22 +03:00
qt-ble.cpp
qt-ble: purge pending read data when writing
2018-06-20 16:38:04 +09:00
qt-ble.h
Convert our custom IO model to new libdivecomputer IO model
2018-04-24 17:54:08 -07:00
qt-gui.h
ssrf: add shared helper file
2018-07-12 08:08:00 -07:00
qt-init.cpp
core: remove SettingsObjectWrapper and update qPref calls
2018-08-15 16:11:39 -07:00
qthelper.cpp
Cleanup: pass gasmix by value
2018-08-23 05:16:38 -07:00
qthelper.h
For media file open dialog add different file filters
2018-07-15 09:38:12 -07:00
qtserialbluetooth.cpp
Make sure our libdivecomputer custom IO interfaces have sleep functions
2018-07-13 11:25:38 -07:00
save-git.c
Cleanup: pass gasmix by value
2018-08-23 05:16:38 -07:00
save-html.c
save-html: make sure that some strings are quoted
2018-08-23 05:01:32 -07:00
save-html.h
Add SPDX header to core C files
2017-04-29 13:32:55 -07:00
save-xml.c
Cleanup: pass gasmix by value
2018-08-23 05:16:38 -07:00
serial_ftdi.c
Use hex USB VID/PID
2018-08-12 15:37:21 -07:00
sha1.c
Move subsurface-core to core and qt-mobile to mobile-widgets
2016-04-04 22:33:58 -07:00
sha1.h
Move subsurface-core to core and qt-mobile to mobile-widgets
2016-04-04 22:33:58 -07:00
ssrf.h
mobile: add timer to measure startup.
2018-05-30 21:47:07 -07:00
statistics.c
Cleanup: pass gasmix by value
2018-08-23 05:16:38 -07:00
statistics.h
Cleanup: fold core/helpers.h into core/qthelper.h
2018-06-04 08:50:10 -07:00
strndup.h
Add SPDX header to core C files
2017-04-29 13:32:55 -07:00
strtod.c
Core: introduce new subsurface-string header
2018-05-14 10:13:39 -07:00
subsurface-string.h
Core: don't inline rarely used function
2018-05-14 10:13:39 -07:00
subsurfacestartup.c
Cleanup: shrink size of three-letter month name strings to 4
2018-08-02 08:55:08 -07:00
subsurfacestartup.h
Fix ownership issues in preferences code
2017-11-25 07:41:09 -08:00
subsurfacesysinfo.cpp
Random whitespace cleanup
2017-05-27 11:07:20 -07:00
subsurfacesysinfo.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
taxonomy.c
Fix two bugs in taxonomy_set_country
2017-10-07 08:16:53 -07:00
taxonomy.h
Add taxonomy helper functions
2017-10-04 08:05:09 -07:00
time.c
Add SPDX header to core C files
2017-04-29 13:32:55 -07:00
uemis-downloader.c
Core: introduce new subsurface-string header
2018-05-14 10:13:39 -07:00
uemis.c
Core: remove dive.h from files that don't need it
2018-05-14 10:13:39 -07:00
uemis.h
Add SPDX header to core C files
2017-04-29 13:32:55 -07:00
units.h
core: removed clang warnings from units.h
2018-05-18 21:27:37 +03:00
unix.c
Cleanup: fix warning in unix.c
2018-08-14 14:13:52 -07:00
version.c
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
version.h
Move subsurface-core to core and qt-mobile to mobile-widgets
2016-04-04 22:33:58 -07:00
videoframeextractor.cpp
Dive media: Extract thumbnails from videos with ffmpeg
2018-07-28 15:31:25 -07:00
videoframeextractor.h
Dive media: Extract thumbnails from videos with ffmpeg
2018-07-28 15:31:25 -07:00
webservice.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
windows.c
core: replace (void) with UNUSED(x) and include ssrf.h
2018-05-24 08:34:14 -07:00
windowtitleupdate.cpp
Cleanup: Make WindowsTitleUpdate a global object
2018-07-30 13:55:23 -07:00
windowtitleupdate.h
Cleanup: Make WindowsTitleUpdate a global object
2018-07-30 13:55:23 -07:00
worldmap-options.h
Add SPDX header to core C files
2017-04-29 13:32:55 -07:00
worldmap-save.c
Core: remove dive.h from files that don't need it
2018-05-14 10:13:39 -07:00
worldmap-save.h
Add SPDX header to core C files
2017-04-29 13:32:55 -07:00