FlapJackApps/subsurface
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
subsurface/core
History
Berthold Stoeger 2c6b1a99af Cleanup: simplify dive_getUniqID() 
dive_getUniqID() is used to create unique dive ids, which are
stable during application lifetime. It was passed a dive, checked
that the id was not set (if it was that it is know to the application)
and set a new id (in contradiction to its name!) if it hadn't any.

There were three callers:

alloc_dive(): called the function on a zeroed dive struct.
fixup_dive(): called the function only if the dive had a 0 id.
MainWindow::setupForAddAndPlan(): called the function on a zeroed dive
struct.

Thus, in all three callers the id is guaranteed to be zero and
the whole keeping-track-of-ids logic is moot. Remove the logic,
don't pass a dive struct to dive_getUniqID() and move the function
to the C-backend.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2018-07-17 15:20:52 -07:00
..
settings
core: solve copy/paste error in qPref_private
2018-07-15 14:35:31 +02:00
subsurface-qt
core: remove Animations from SettingsObjectWrapper and activate qPrefAnimations
2018-07-12 22:34:35 +02:00
android.cpp
Cleanup: introduce copy_qstring() function
2018-03-14 13:55:36 +02:00
btdiscovery.cpp
Correctly recognize more OSTC variants as BLE
2018-07-02 09:24:30 -07:00
btdiscovery.h
Cleanup: Use QString as parameter for [get|save]BtDeviceInfo()
2018-02-26 08:52:34 +01:00
checkcloudconnection.cpp
Cleanup: fold core/helpers.h into core/qthelper.h
2018-06-04 08:50:10 -07:00
checkcloudconnection.h
Remove self-include of core/checkcloudconnection.h
2017-12-06 02:23:47 +01:00
cloudstorage.cpp
core: make qPref::cloud_status the only version of the enum
2018-07-10 10:30:50 -07:00
cloudstorage.h
Remove bogus member that hides global variable
2017-10-26 20:44:02 +02:00
CMakeLists.txt
core: copy Animations from SettingsObjectWrapper to qPref as its own class
2018-07-12 19:07:49 +02:00
cochran.c
core: replace (void) with UNUSED(x) and include ssrf.h
2018-05-24 08:34:14 -07:00
cochran.h
Cochran import: better support for older models
2017-05-31 21:53:00 -07:00
color.cpp
Fix CCR setpoint display bug
2018-05-07 13:56:23 +02:00
color.h
Plot OC-pO2 graph for SCR dives
2018-04-28 20:11:22 +03:00
compressibility.r
Move subsurface-core to core and qt-mobile to mobile-widgets
2016-04-04 22:33:58 -07:00
configuredivecomputer.cpp
Actually tie in the new libdivecomputer IO model to open the dive computer device
2018-04-24 17:54:08 -07:00
configuredivecomputer.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
configuredivecomputerthreads.cpp
core: Change Q_UNUSED to no parameter name
2018-05-21 12:48:04 -07:00
configuredivecomputerthreads.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
connectionlistmodel.cpp
core: Change Q_UNUSED to no parameter name
2018-05-21 12:48:04 -07:00
connectionlistmodel.h
Add function to clear connectionModel data
2017-10-12 09:32:12 +02:00
datatrak.c
Core: remove dive.h from files that don't need it
2018-05-14 10:13:39 -07:00
datatrak.h
Datatrak import rework: Add another memory size ckeck
2017-05-07 07:48:12 -07:00
deco.c
core: replace (void) with UNUSED(x) and include ssrf.h
2018-05-24 08:34:14 -07:00
deco.h
Localize global planner state
2017-11-25 20:13:01 +01:00
device.c
core: replace (void) with UNUSED(x) and include ssrf.h
2018-05-24 08:34:14 -07:00
device.h
Core: remove dive.h from files that don't need it
2018-05-14 10:13:39 -07:00
devicedetails.cpp
Implement OSTC4 specific settings
2017-05-04 10:50:15 -07:00
devicedetails.h
Implement OSTC4 specific settings
2017-05-04 10:50:15 -07:00
display.h
Display values in info box only if value is interesting
2017-11-13 20:50:10 -08:00
dive.c
Cleanup: simplify dive_getUniqID()
2018-07-17 15:20:52 -07:00
dive.h
Cleanup: simplify dive_getUniqID()
2018-07-17 15:20:52 -07:00
divecomputer.cpp
core: remove prefs-macros.h where unused
2018-07-01 22:06:28 +02:00
divecomputer.h
Dive computers: turn QMultiMap into sorted vector
2018-06-17 06:53:13 +09:00
divelist.c
Don't compute SAC if total gas use is unknown
2018-05-28 09:57:00 +02:00
divelist.h
Unused code: remove trip_has_selected_dives()
2018-01-10 16:45:42 +01:00
divelogexportlogic.cpp
Translations: unify gettextFromC::tr() and QObject::tr()
2018-07-04 05:33:31 +08:00
divelogexportlogic.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
divesite-helper.cpp
Translations: unify gettextFromC::tr() and QObject::tr()
2018-07-04 05:33:31 +08:00
divesite.c
core: remove clang warning in divesite.c
2018-07-11 12:59:33 +02:00
divesite.h
Tags for geo references: Nicer look, translations and warning message
2017-10-17 06:12:07 -04:00
divesitehelpers.cpp
Cleanup: fold core/helpers.h into core/qthelper.h
2018-06-04 08:50:10 -07:00
divesitehelpers.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
downloadfromdcthread.cpp
Add Cressi Giotto, Newton and Drake to list of devices
2018-06-28 11:52:24 +08:00
downloadfromdcthread.h
core: remove qml properties from downloadfromcthread
2018-06-09 21:19:46 +02:00
equipment.c
equipment: use MAX_TANK_INFO in equipment.c
2018-06-20 09:30:58 +09:00
errorhelper.c
Make report_error() reentrant
2018-01-31 14:47:26 +01:00
exif.cpp
Coding-style: remove superfluous parentheses
2018-02-17 19:38:52 -08:00
exif.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
file.c
core: replace (void) with UNUSED(x) and include ssrf.h
2018-05-24 08:34:14 -07:00
file.h
Make a few functions of static linkage
2018-01-08 09:52:55 +02:00
format.cpp
Cleanup: Slightly shorten code in vqasprintf_loc()
2018-04-09 11:29:43 -07:00
format.h
Cleanup: Move *_loc formatting functions into new format.cpp file
2018-04-09 11:29:43 -07:00
gas-model.c
Compute and display gas density
2017-05-26 15:52:04 -07:00
gaspressures.c
Provide correct cylinder pressures for bailout dives
2018-06-08 17:07:20 +03:00
gaspressures.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
gettext.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
gettextfromc.cpp
Localization: make cache thread safe and robust against use-after-free
2018-06-24 20:31:14 +02:00
gettextfromc.h
Localization: remove gettextFromC::instance()
2018-06-24 20:31:14 +02:00
git-access.c
core: replace (void) with UNUSED(x) and include ssrf.h
2018-05-24 08:34:14 -07:00
git-access.h
Support non-https:// repositories for saving
2018-01-19 09:45:08 +02:00
gpslocation.cpp
Cleanup: fold core/helpers.h into core/qthelper.h
2018-06-04 08:50:10 -07:00
gpslocation.h
Translations: unify gettextFromC::tr() and QObject::tr()
2018-07-04 05:33:31 +08:00
imagedownloader.cpp
Dive pictures: differentiate between IO-error and unknown format
2018-07-09 09:12:58 -07:00
imagedownloader.h
Dive pictures: differentiate between IO-error and unknown format
2018-07-09 09:12:58 -07:00
import-cobalt.c
core: replace (void) with UNUSED(x) and include ssrf.h
2018-05-24 08:34:14 -07:00
import-csv.c
Core: introduce new subsurface-string header
2018-05-14 10:13:39 -07:00
import-csv.h
Make a few functions of static linkage
2018-01-08 09:52:55 +02:00
import-divinglog.c
core: replace (void) with UNUSED(x) and include ssrf.h
2018-05-24 08:34:14 -07:00
import-shearwater.c
Remove unnecessary {}
2018-05-27 23:18:01 +03:00
import-suunto.c
DM5 import: support for larger sample size
2018-06-15 17:45:33 -07:00
ios.cpp
core: Change Q_UNUSED to no parameter name
2018-05-21 12:48:04 -07:00
isocialnetworkintegration.cpp
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
isocialnetworkintegration.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
libdivecomputer.c
FTDI support: try ftdi_open first if the device name is 'ftdi'
2018-06-21 16:16:29 +09:00
libdivecomputer.h
Create one function to determine the supported transports
2018-04-27 11:52:48 -07:00
linux.c
save-git: allocate user_info members on the heap
2018-07-07 17:42:10 -07:00
liquivision.c
core: replace (void) with UNUSED(x) and include ssrf.h
2018-05-24 08:34:14 -07:00
load-git.c
git storage: avoid warning about "Unmatched action 'hash'"
2018-07-07 07:35:45 -07:00
macos.c
core: replace (void) with UNUSED(x) and include ssrf.h
2018-05-24 08:34:14 -07:00
membuffer.c
Localization: Make Qt's locale-aware formatting accessible from C
2018-03-05 16:23:55 +01:00
membuffer.h
Add usage documentation for membuffer helper functions
2018-04-10 08:18:32 -07:00
metadata.cpp
Metadata: Parse ASFs (=WMVs)
2018-07-14 08:32:30 +02:00
metadata.h
Metadata: extract duration fom QuickTime/MP4-style containers
2018-07-14 08:32:30 +02:00
metrics.cpp
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
metrics.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
ostctools.c
Core: introduce new subsurface-string header
2018-05-14 10:13:39 -07:00
parse-xml.c
Dive pictures: remove hashes
2018-07-04 02:27:36 +08:00
parse.c
core: replace (void) with UNUSED(x) and include ssrf.h
2018-05-24 08:34:14 -07:00
parse.h
Don't define cur_setting in header file
2018-01-05 00:29:20 +01:00
planner.c
Fix interpretation of dive mode changes upon replan
2018-06-24 09:35:55 +02:00
planner.h
Move planner notes to separate file
2017-05-26 15:44:36 -07:00
plannernotes.c
In planner notes don't show dive mode for first data point
2018-07-13 11:26:28 -07:00
pluginmanager.cpp
Unused code: remove PluginManager::socialNetworkIntegrationPlugins()
2018-01-10 16:45:42 +01:00
pluginmanager.h
Unused code: remove PluginManager::socialNetworkIntegrationPlugins()
2018-01-10 16:45:42 +01:00
pref.h
core: make qPref::cloud_status the only version of the enum
2018-07-10 10:30:50 -07:00
prefs-macros.h
core: make prefs-macros compile safe.
2018-06-15 14:11:57 -07:00
profile.c
core: replace (void) with UNUSED(x) and include ssrf.h
2018-05-24 08:34:14 -07:00
profile.h
Plot OC-pO2 graph for SCR dives
2018-04-28 20:11:22 +03:00
qt-ble.cpp
qt-ble: purge pending read data when writing
2018-06-20 16:38:04 +09:00
qt-ble.h
Convert our custom IO model to new libdivecomputer IO model
2018-04-24 17:54:08 -07:00
qt-gui.h
ssrf: add shared helper file
2018-07-12 08:08:00 -07:00
qt-init.cpp
Disable the WindowContextHelpButtonHint for Qt >=5.10
2018-07-13 14:46:10 -07:00
qthelper.cpp
Cleanup: simplify dive_getUniqID()
2018-07-17 15:20:52 -07:00
qthelper.h
For media file open dialog add different file filters
2018-07-15 09:38:12 -07:00
qtserialbluetooth.cpp
Make sure our libdivecomputer custom IO interfaces have sleep functions
2018-07-13 11:25:38 -07:00
save-git.c
save-git: allocate user_info members on the heap
2018-07-07 17:42:10 -07:00
save-html.c
Cleanup: Unify qthelper.h and qthelperfromc.h
2018-02-26 19:06:02 +02:00
save-html.h
Add SPDX header to core C files
2017-04-29 13:32:55 -07:00
save-xml.c
Dive pictures: remove hashes
2018-07-04 02:27:36 +08:00
serial_ftdi.c
Make sure our libdivecomputer custom IO interfaces have sleep functions
2018-07-13 11:25:38 -07:00
sha1.c
Move subsurface-core to core and qt-mobile to mobile-widgets
2016-04-04 22:33:58 -07:00
sha1.h
Move subsurface-core to core and qt-mobile to mobile-widgets
2016-04-04 22:33:58 -07:00
ssrf.h
mobile: add timer to measure startup.
2018-05-30 21:47:07 -07:00
statistics.c
Fix an error around translation of dive modes in the UI
2018-06-17 06:36:20 +09:00
statistics.h
Cleanup: fold core/helpers.h into core/qthelper.h
2018-06-04 08:50:10 -07:00
strndup.h
Add SPDX header to core C files
2017-04-29 13:32:55 -07:00
strtod.c
Core: introduce new subsurface-string header
2018-05-14 10:13:39 -07:00
subsurface-string.h
Core: don't inline rarely used function
2018-05-14 10:13:39 -07:00
subsurfacestartup.c
Dive pictures: remove hashes
2018-07-04 02:27:36 +08:00
subsurfacestartup.h
Fix ownership issues in preferences code
2017-11-25 07:41:09 -08:00
subsurfacesysinfo.cpp
Random whitespace cleanup
2017-05-27 11:07:20 -07:00
subsurfacesysinfo.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
taxonomy.c
Fix two bugs in taxonomy_set_country
2017-10-07 08:16:53 -07:00
taxonomy.h
Add taxonomy helper functions
2017-10-04 08:05:09 -07:00
time.c
Add SPDX header to core C files
2017-04-29 13:32:55 -07:00
uemis-downloader.c
Core: introduce new subsurface-string header
2018-05-14 10:13:39 -07:00
uemis.c
Core: remove dive.h from files that don't need it
2018-05-14 10:13:39 -07:00
uemis.h
Add SPDX header to core C files
2017-04-29 13:32:55 -07:00
units.h
core: removed clang warnings from units.h
2018-05-18 21:27:37 +03:00
version.c
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
version.h
Move subsurface-core to core and qt-mobile to mobile-widgets
2016-04-04 22:33:58 -07:00
webservice.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
windows.c
core: replace (void) with UNUSED(x) and include ssrf.h
2018-05-24 08:34:14 -07:00
windowtitleupdate.cpp
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
windowtitleupdate.h
Add SPDX header to remaining core files
2017-04-29 13:32:55 -07:00
worldmap-options.h
Add SPDX header to core C files
2017-04-29 13:32:55 -07:00
worldmap-save.c
Core: remove dive.h from files that don't need it
2018-05-14 10:13:39 -07:00
worldmap-save.h
Add SPDX header to core C files
2017-04-29 13:32:55 -07:00