FlapJackApps/subsurface
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
subsurface/desktop-widgets
History
Berthold Stoeger 285ea9b7ca Cleanup: don't initialize DivePlannerPointsModel at startup 
The whole point of having X::instance() functions is to solve
the infamous "Static Initialization Order Fiasco": When having
global objects in different translation units, their order
of initialization is undefined. Thus, when these objects access
each other one cannot guarantee the correct order of
initialization. The X::instance() functions generate the objects
on first use.

DivePlannerPointsModel has such an instance() function. However,
for convenience(?) in diveplanner.cpp we find the global variable
 static DivePlannerPointsModel* plannerModel =
	DivePlannerPointsModel::instance();
Thus, the DivePlannerPointsModel constructor is run before main(),
negating the whole purpose of the instance() function.

Let's remove this line to avoid hard-to-debug startup issues.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2020-02-06 08:51:32 -08:00
..
css
Move qt-ui to desktop-widgets
2015-10-30 10:36:49 -07:00
preferences
core/settings:: remove string functions for units
2020-01-20 09:55:26 -08:00
statistics
Cleanup: reinstate override modifiers
2018-09-29 15:23:25 -07:00
tab-widgets
Cleanup: lower-case filenames in core/subsurface-qt/
2020-02-04 02:16:46 +01:00
about.cpp
update year to 2019 in about screens
2019-01-02 09:45:01 -08:00
about.h
Add SPDX header to desktop widgets
2017-04-29 13:32:55 -07:00
about.ui
Use icons relative path.
2017-11-30 23:14:46 -08:00
btdeviceselectiondialog.cpp
code cleanup: replace deprecated setBackgroundColor() method
2020-01-10 02:37:03 +09:00
btdeviceselectiondialog.h
Bluetooth: use standard Qt code on Windows
2018-09-30 08:09:37 -07:00
btdeviceselectiondialog.ui
Desktop: add checkbox to show all BT devices
2019-02-14 09:05:58 -08:00
CMakeLists.txt
Desktop: Import dive coordinates directly from GPS
2020-01-24 09:51:02 -08:00
configuredivecomputerdialog.cpp
Cleanup: we don't support configuring a Uemis SDA
2018-08-28 12:03:03 -07:00
configuredivecomputerdialog.h
Cleanup: reinstate override modifiers
2018-09-29 15:23:25 -07:00
configuredivecomputerdialog.ui
Configure ostc3: Remove obsoleted setting
2018-04-27 21:33:47 +03:00
divecomponentselection.ui
Add various enhancements to profile export and dive data copy
2019-02-07 16:06:43 +01:00
divecomputermanagementdialog.cpp
Dive computers: turn QMultiMap into sorted vector
2018-06-17 06:53:13 +09:00
divecomputermanagementdialog.h
Cleanup: fold DiveComputerManagementDialog::update() into init()
2018-06-17 06:53:13 +09:00
divecomputermanagementdialog.ui
Use icons relative path.
2017-11-30 23:14:46 -08:00
divelistview.cpp
Dive sites: select each dive site only once
2020-02-04 02:18:28 +01:00
divelistview.h
Cleanup: lower-case filenames in core/subsurface-qt/
2020-02-04 02:16:46 +01:00
divelogexportdialog.cpp
build-system: move exportfuncs to backend-shared
2019-12-24 08:44:23 +09:00
divelogexportdialog.h
desktop-widgets: move export functions to shared class
2019-12-03 21:30:39 -08:00
divelogexportdialog.ui
Add export option to export dive sites.
2019-04-13 08:18:32 -07:00
divelogimportdialog.cpp
code cleanup: add empty table structures
2020-01-10 02:37:03 +09:00
divelogimportdialog.h
Import: Make DiveLogImportDialog modal
2018-10-04 10:22:11 +02:00
divelogimportdialog.ui
Use icons relative path.
2017-11-30 23:14:46 -08:00
divepicturewidget.cpp
Dive media: transport dive-id in drag'n'drop events
2018-07-18 09:06:37 -07:00
divepicturewidget.h
Cleanup: reinstate override modifiers
2018-09-29 15:23:25 -07:00
diveplanner.cpp
Cleanup: don't initialize DivePlannerPointsModel at startup
2020-02-06 08:51:32 -08:00
diveplanner.h
code cleanup: remove unused QSignalMapper
2020-01-10 02:37:03 +09:00
diveplanner.ui
Choose water presets from a qcombobox in planner, custom value possible
2018-03-02 08:38:22 -08:00
diveshareexportdialog.cpp
desktop-widgets: diveDiveShareExportDialog add signal handling
2019-12-11 11:08:51 -05:00
diveshareexportdialog.h
desktop-widgets: diveDiveShareExportDialog add signal handling
2019-12-11 11:08:51 -05:00
diveshareexportdialog.ui
Move qt-ui to desktop-widgets
2015-10-30 10:36:49 -07:00
divesiteimportdialog.cpp
code cleanup: add empty table structures
2020-01-10 02:37:03 +09:00
divesiteimportdialog.h
Create DivesiteImportDialog to select sites to import
2019-05-06 10:48:44 +02:00
divesiteimportdialog.ui
Create DivesiteImportDialog to select sites to import
2019-05-06 10:48:44 +02:00
downloadfromdivecomputer.cpp
Refactoring: move undo commands to top level
2019-11-14 21:02:07 +01:00
downloadfromdivecomputer.h
Import: Make DownloadThread a subobject of DiveImportedModel
2019-10-02 08:04:49 -07:00
downloadfromdivecomputer.ui
Desktop/remember DCs: avoid highlighted button
2018-09-23 11:49:30 -07:00
filterwidget2.cpp
Filter: split out filter from model
2019-11-19 21:13:40 -08:00
filterwidget2.h
Filter: split out filter from model
2019-11-19 21:13:40 -08:00
filterwidget2.ui
Desktop: correct tooltip for filter close button
2019-07-29 07:24:05 +02:00
findmovedimagesdialog.cpp
Desktop: fix another variable name conflict
2019-03-18 19:40:32 -07:00
findmovedimagesdialog.h
Dive pictures: implement FindMovedImagesDialog
2018-07-04 02:27:36 +08:00
findmovedimagesdialog.ui
UI change of "images"/"photo" to "media" or "media files"
2018-07-15 09:38:12 -07:00
groupedlineedit.cpp
Unused code: GroupedLineEdit::removeAllColors()
2018-01-10 16:45:42 +01:00
groupedlineedit.h
Cleanup: reinstate override modifiers
2018-09-29 15:23:25 -07:00
importgps.cpp
core: move GPX parsing into core
2020-01-24 09:51:02 -08:00
importgps.h
core: move GPX parsing into core
2020-01-24 09:51:02 -08:00
importgps.ui
Desktop: Import dive coordinates directly from GPS
2020-01-24 09:51:02 -08:00
kmessagewidget.cpp
Add SPDX header to desktop widgets
2017-04-29 13:32:55 -07:00
kmessagewidget.h
Cleanup: reinstate override modifiers
2018-09-29 15:23:25 -07:00
listfilter.ui
Start to implement a simplified version of the filter widget
2018-12-14 01:05:18 +08:00
locationinformation.cpp
Dive site: don't save invalid GPS coordinates
2020-02-06 08:50:22 -08:00
locationinformation.h
Dive site: give visual clue for invalid coordinates
2020-02-06 08:50:22 -08:00
locationinformation.ui
Desktop: Import dive coordinates directly from GPS
2020-01-24 09:51:02 -08:00
mainwindow.cpp
Cleanup: lower-case filenames in core/subsurface-qt/
2020-02-04 02:16:46 +01:00
mainwindow.h
Cleanup: remove MainWindow::recreateDiveList() function
2019-11-19 21:13:40 -08:00
mainwindow.ui
Reword configure dive computer
2019-06-03 19:55:19 +02:00
mapwidget.cpp
Refactoring: move undo commands to top level
2019-11-14 21:02:07 +01:00
mapwidget.h
Cleanup: lower-case filenames in core/subsurface-qt/
2020-02-04 02:16:46 +01:00
modeldelegates.cpp
code cleanup: use explicit zero_location
2020-01-10 02:37:03 +09:00
modeldelegates.h
Desktop: refactor WSInfoDelegate logic
2019-12-05 10:14:25 -08:00
notificationwidget.cpp
Use queued connection to thread-safe MainWindow error handling
2018-01-31 14:47:26 +01:00
notificationwidget.h
Use queued connection to thread-safe MainWindow error handling
2018-01-31 14:47:26 +01:00
plannerDetails.ui
Bring back style sheet HTML for planner output
2017-02-24 01:06:09 -08:00
plannerSettings.ui
Planner: Add option to treat O2 as narcotic
2019-10-31 00:30:38 -07:00
printdialog.cpp
Add the ability to export print template as html
2019-09-11 17:21:50 +01:00
printdialog.h
Add the ability to export print template as html
2019-09-11 17:21:50 +01:00
printer.cpp
Add the ability to export print template as html
2019-09-11 17:21:50 +01:00
printer.h
Add the ability to export print template as html
2019-09-11 17:21:50 +01:00
printoptions.cpp
replace deprecated qSort() with std::sort()
2019-04-12 12:59:17 +03:00
printoptions.h
Cleanup: remove all Q_NULLPTR instances
2019-04-02 07:34:46 -07:00
printoptions.ui
Move qt-ui to desktop-widgets
2015-10-30 10:36:49 -07:00
qtwaitingspinner.cpp
Move qt-ui to desktop-widgets
2015-10-30 10:36:49 -07:00
qtwaitingspinner.h
Move qt-ui to desktop-widgets
2015-10-30 10:36:49 -07:00
renumber.ui
Use icons relative path.
2017-11-30 23:14:46 -08:00
searchbar.ui
Use better aliases for icons.
2017-11-30 23:14:46 -08:00
setpoint.ui
Use icons relative path.
2017-11-30 23:14:46 -08:00
shiftimagetimes.ui
UI change of "images"/"photo" to "media" or "media files"
2018-07-15 09:38:12 -07:00
shifttimes.ui
Use icons relative path.
2017-11-30 23:14:46 -08:00
simplewidgets.cpp
code cleanup: remove deprecated QString::null
2020-01-10 02:37:03 +09:00
simplewidgets.h
Cleanup: remove Q_PROPERTYs from MinMaxWidget
2019-06-10 17:59:35 +03:00
starwidget.cpp
code cleanup: replace deprecated member function QColor::dark()
2020-01-10 02:37:03 +09:00
starwidget.h
Cleanup: reinstate override modifiers
2018-09-29 15:23:25 -07:00
subsurfacewebservices.cpp
code cleanup: add empty table structures
2020-01-10 02:37:03 +09:00
subsurfacewebservices.h
desktop-widgets: divelogsDE: integrate shared backend
2019-12-11 12:36:43 -05:00
tableview.cpp
code cleanup: QFontMetrics::width() is deprecated
2020-01-10 02:37:03 +09:00
tableview.h
Desktop: don't connect to remove() slot of model from TableModel
2019-12-05 10:14:25 -08:00
tableview.ui
Move qt-ui to desktop-widgets
2015-10-30 10:36:49 -07:00
tagwidget.cpp
Desktop: remove edit-check in tag-widget completer
2019-04-14 03:38:22 +12:00
tagwidget.h
Undo: implement undo of tag editing
2019-04-12 18:19:07 +03:00
templateedit.cpp
Warnings: replace memcpy by assignment
2018-11-19 13:51:03 -08:00
templateedit.h
Add SPDX header to desktop widgets
2017-04-29 13:32:55 -07:00
templateedit.ui
templateedit.ui: give the layout for "Border width" unique name
2017-03-12 09:19:03 -07:00
templatelayout.cpp
Selection: move selection functions from divelist.c to selection.c
2019-12-04 13:00:23 +01:00
templatelayout.h
Cleanup: lower-case filenames in core/subsurface-qt/
2020-02-04 02:16:46 +01:00
textedit.cpp
Desktop: create new custom TextEdit widget for notes-field
2019-04-12 18:19:07 +03:00
textedit.h
Desktop: create new custom TextEdit widget for notes-field
2019-04-12 18:19:07 +03:00
updatemanager.cpp
core: move updatecheck to its own domain
2019-02-09 10:37:55 -08:00
updatemanager.h
Add SPDX header to desktop widgets
2017-04-29 13:32:55 -07:00
urldialog.ui
UI change of "images"/"photo" to "media" or "media files"
2018-07-15 09:38:12 -07:00
usermanual.cpp
Coding style: remove Java-style function definition
2019-04-12 18:19:07 +03:00
usermanual.h
Remove partial support for QWebEngine
2019-03-20 08:45:02 -07:00
usersurvey.cpp
Revert "desktop-widgets: remove QSettings from desktop-widgets"
2018-08-29 03:09:10 -07:00
usersurvey.h
Add SPDX header to desktop widgets
2017-04-29 13:32:55 -07:00
usersurvey.ui
fix: User survey UI.
2017-03-06 06:40:00 -08:00
webservices.ui
Use icons relative path.
2017-11-30 23:14:46 -08:00