From ead15f622a3891794e68bb48974f593d0e767ac5 Mon Sep 17 00:00:00 2001 From: Dirk Hohndel Date: Tue, 30 Aug 2022 12:38:40 -0700 Subject: [PATCH] mobile: remove export as UDDF The export functionality is horridly poorly implemented, and the UDDF export isn't actually functional on mobile. And why would we support this in the first place? That's not a reasonable expectation for the mobile app. So let's just completely remove that and good riddance. Signed-off-by: Dirk Hohndel --- mobile-widgets/qml/Export.qml | 8 -------- mobile-widgets/qmlmanager.cpp | 3 --- mobile-widgets/qmlmanager.h | 1 - 3 files changed, 12 deletions(-) diff --git a/mobile-widgets/qml/Export.qml b/mobile-widgets/qml/Export.qml index 4f89334e3..9d48dcaec 100644 --- a/mobile-widgets/qml/Export.qml +++ b/mobile-widgets/qml/Export.qml @@ -152,14 +152,6 @@ TemplatePage { explain.text = qsTr("Subsurface dive sites native XML format.") } } - TemplateRadioButton { - text: qsTr("Export UDDF") - visible: Qt.platform.os !== "android" - onClicked: { - selectedExport = ExportType.EX_UDDF - explain.text = qsTr("Generic format that is used for data exchange between a variety of diving related programs.") - } - } TemplateRadioButton { text: qsTr("Upload divelogs.de") onClicked: { diff --git a/mobile-widgets/qmlmanager.cpp b/mobile-widgets/qmlmanager.cpp index 003d1bcce..109160680 100644 --- a/mobile-widgets/qmlmanager.cpp +++ b/mobile-widgets/qmlmanager.cpp @@ -2211,9 +2211,6 @@ void QMLManager::exportToFile(export_types type, QString dir, bool anonymize) save_dive_sites_logic(qPrintable(fileName + ".xml"), sites.data(), (int)sites.size(), anonymize); break; } - case EX_UDDF: - exportUsingStyleSheet(fileName + ".uddf", true, 0, "uddf-export.xslt", anonymize); - break; default: qDebug() << "export to unknown type " << type << " using " << dir << " remove names " << anonymize; break; diff --git a/mobile-widgets/qmlmanager.h b/mobile-widgets/qmlmanager.h index 717b18510..3776af5b6 100644 --- a/mobile-widgets/qmlmanager.h +++ b/mobile-widgets/qmlmanager.h @@ -66,7 +66,6 @@ public: enum export_types { EX_DIVES_XML, EX_DIVE_SITES_XML, - EX_UDDF, EX_DIVELOGS_DE, EX_DIVESHARE };