From dcad3af8b63558d9d62cf995de6b4043c3f751fb Mon Sep 17 00:00:00 2001 From: "Lubomir I. Ivanov" Date: Thu, 21 Feb 2013 03:07:22 +0200 Subject: [PATCH] parse-xml.c: fixed a small memory leak related to xmlGetProp() test_xslt_transforms(): xmlGetProp uses strdup(), so we have to clear the memory if a pointer is returned. xmlFree() doesn't seem very portable (strangly enought), so we use free(..) directly. Signed-off-by: Lubomir I. Ivanov Signed-off-by: Dirk Hohndel --- parse-xml.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/parse-xml.c b/parse-xml.c index 2f35a4fbe..b44d992cd 100644 --- a/parse-xml.c +++ b/parse-xml.c @@ -1549,8 +1549,13 @@ xmlDoc *test_xslt_transforms(xmlDoc *doc) if (info->root) { attribute = xmlGetProp(xmlFirstElementChild(root_element), "name"); - if (attribute && (strcasecmp(attribute, "subsurface") == 0)) - return doc; + if (attribute) { + if (strcasecmp(attribute, "subsurface") == 0) { + free((void *)attribute); + return doc; + } + free((void *)attribute); + } xmlSubstituteEntitiesDefault(1); xslt = get_stylesheet(info->file);