FlapJackApps/subsurface
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Divelist: fix a crash when updating the preferences

Browse Source 
Hitting apply in the preferences dialog causes a QList assert.
This led to DiveListView::reloadHeaderActions(), where
we have an out of range access.

Patch makes the column count match the header action count.

Signed-off-by: Lubomir I. Ivanov <neolit123@gmail.com>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Lubomir I. Ivanov
2013-12-04 18:20:33 +02:00
committed by Dirk Hohndel
parent fc06a69c43
commit d7a19b318e
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
qt-ui/divelistview.cpp
View File

@@ -391,10 +391,9 @@ void DiveListView::reloadHeaderActions()
} }
s.endGroup(); s.endGroup();
} else { } else {
// Skip first QAction item ( static text Visible )
for(int i = 0; i < model()->columnCount(); i++) { for(int i = 0; i < model()->columnCount(); i++) {
QString title = QString("%1").arg(model()->headerData(i, Qt::Horizontal).toString()); QString title = QString("%1").arg(model()->headerData(i, Qt::Horizontal).toString());
header()->actions()[i+1]->setText( title ); header()->actions()[i]->setText(title);
} }
} }
} }