FlapJackApps/subsurface
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

core/imagedownloader.cpp: Fix memory leak

Browse Source 
A cloned picture struct would not be freed if the filename was already
in the queued-for-download set.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2018-02-08 22:05:29 +01:00 committed by Lubomir I. Ivanov
parent 93ddcce6fa
commit c1cd2e0f02
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
core/imagedownloader.cpp
View File

@ -86,8 +86,10 @@ static void loadPicture(struct picture *picture, bool fromHash)
if (!picture)
return;
QMutexLocker locker(&pictureQueueMutex);
if (queuedPictures.contains(QString(picture->filename)))
if (queuedPictures.contains(QString(picture->filename))) {
picture_free(picture);
return;
}
queuedPictures.insert(QString(picture->filename));
locker.unlock();