FlapJackApps/subsurface
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cleanup: fix over-eager Coverity warnings

Browse Source 
Technically get_dive(i) could return a nullptr. But given the range for i that
can never happen. Still, the test is extremely cheap and doesn't hurt.

Fixes CID 354768
Fixes CID 354766

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Dirk Hohndel 2020-10-24 14:43:32 -07:00
parent b7a586a5b4
commit a64787f70d
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
qt-models/divetripmodel.cpp
View File

@ -716,6 +716,8 @@ void DiveTripModelTree::populate()
uiNotification(QObject::tr("start processing"));
for (int i = 0; i < dive_table.nr; ++i) {
dive *d = get_dive(i);
if (!d) // should never happen
continue;
update_cylinder_related_info(d);
if (d->hidden_by_filter)
continue;
@ -1482,7 +1484,7 @@ void DiveTripModelList::populate()
items.reserve(dive_table.nr);
for (int i = 0; i < dive_table.nr; ++i) {
dive *d = get_dive(i);
if (d->hidden_by_filter)
if (!d || d->hidden_by_filter)
continue;
items.push_back(d);
}