From 9452a78b1d9f69121d81f345a5c3dbf2e100cf74 Mon Sep 17 00:00:00 2001 From: jan Iversen Date: Thu, 30 Jan 2020 10:45:55 +0100 Subject: [PATCH] divesummary: fix potential division by zero [Dirk Hohndel: extracted from a larger commit from Jan] Signed-off-by: jan Iversen Signed-off-by: Dirk Hohndel --- backend-shared/divesummary.cpp | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/backend-shared/divesummary.cpp b/backend-shared/divesummary.cpp index 12d7ff0e2..d9300f429 100644 --- a/backend-shared/divesummary.cpp +++ b/backend-shared/divesummary.cpp @@ -175,9 +175,14 @@ void diveSummary::buildStringList(int inx) unitText = (qPrefUnits::volume() == units::LITER) ? " l/min" : " cuft/min"; diveSummaryText[18+inx] = volumeString(sacMin[inx]) + unitText; diveSummaryText[20+inx] = volumeString(sacMax[inx]) + unitText; + // finally the weighted average - long avgSac = totalSacVolume[inx] / totalSACTime[inx]; - diveSummaryText[22+inx] = volumeString(avgSac) + unitText; + if (totalSACTime[inx]) { + long avgSac = totalSacVolume[inx] / totalSACTime[inx]; + diveSummaryText[22+inx] = volumeString(avgSac) + unitText; + } else { + diveSummaryText[22+inx] = QObject::tr("no dives"); + } // Diveplan(s) diveSummaryText[24+inx] = QStringLiteral("%1").arg(diveplans[inx]);