FlapJackApps/subsurface
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unnecessary deletes in destructor of ProfileWidget2

Browse Source 
All the deleted items were added to the scene, which takes
"ownership" (a remarkably fuzzy concept in Qt) of these
objects. In principle, deleting these items is a bug - even
though it is handled gracefully.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2018-01-08 19:43:01 +01:00 committed by Lubomir I. Ivanov
parent 6193aef9ac
commit 6cf06fb61d
2 changed files with 0 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
profile-widget/profilewidget2.cpp
View File

@ -166,43 +166,6 @@ ProfileWidget2::ProfileWidget2(QWidget *parent) : QGraphicsView(parent),
#endif
}
ProfileWidget2::~ProfileWidget2()
{
delete background;
delete profileYAxis;
delete gasYAxis;
delete temperatureAxis;
delete timeAxis;
delete diveProfileItem;
delete temperatureItem;
delete meanDepthItem;
delete cylinderPressureAxis;
delete gasPressureItem;
delete diveComputerText;
delete reportedCeiling;
delete pn2GasItem;
delete pheGasItem;
delete po2GasItem;
delete o2SetpointGasItem;
delete ccrsensor1GasItem;
delete ccrsensor2GasItem;
delete ccrsensor3GasItem;
#ifndef SUBSURFACE_MOBILE
delete toolTipItem;
delete diveCeiling;
delete heartBeatAxis;
delete heartBeatItem;
delete percentageAxis;
delete ambPressureItem;
delete gflineItem;
delete mouseFollowerVertical;
delete mouseFollowerHorizontal;
delete rulerItem;
#endif
delete tankItem;
}
#define SUBSURFACE_OBJ_DATA 1
#define SUBSURFACE_OBJ_DC_TEXT 0x42

1
profile-widget/profilewidget2.h
View File

@ -137,7 +137,6 @@ slots: // Necessary to call from QAction's signals.
#endif
protected:
virtual ~ProfileWidget2();
void resizeEvent(QResizeEvent *event) Q_DECL_OVERRIDE;
#ifndef SUBSURFACE_MOBILE
void wheelEvent(QWheelEvent *event) Q_DECL_OVERRIDE;