From 61e8ceef05312da1d4a8c8c806e1686b4a0e217b Mon Sep 17 00:00:00 2001
From: Dirk Hohndel <dirk@hohndel.org>
Date: Thu, 16 Dec 2021 21:15:48 -0800
Subject: [PATCH] core: avoid resource leak

That code was obviously wrong from the start.

Fixes CID 373921

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
---
 core/save-xml.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/core/save-xml.c b/core/save-xml.c
index 9f3dc60ce..e2ffb7e7f 100644
--- a/core/save-xml.c
+++ b/core/save-xml.c
@@ -609,12 +609,14 @@ static void save_one_device(struct membuffer *b, const struct device *d)
 
 static void save_one_fingerprint(struct membuffer *b, int i)
 {
+	const char *data = fp_get_data(&fingerprint_table, i);
 	put_format(b, "<fingerprint model='%08x' serial='%08x' deviceid='%08x' diveid='%08x' data='%s'/>\n",
 		   fp_get_model(&fingerprint_table, i),
 		   fp_get_serial(&fingerprint_table, i),
 		   fp_get_deviceid(&fingerprint_table, i),
 		   fp_get_diveid(&fingerprint_table, i),
-		   fp_get_data(&fingerprint_table, i));
+		   data);
+	free((void *)data);
 }
 
 int save_dives(const char *filename)