FlapJackApps/subsurface
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

QML UI: Don't explicitly set width of GridLayout items

Browse Source 
It is not recommended to set the width explicitly of items in a layout. This
caused some issues in DiveDetailsView, which were fixed by commit 1030cb2.
See http://doc.qt.io/qt-5/qml-qtquick-layouts-layout.html#details

Set 'Layout.preferredWidth' instead of 'width' for GpsList and Preferences

Signed-off-by: Rick Walsh <rickmwalsh@gmail.com>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Rick Walsh 2016-01-20 06:44:08 +11:00 committed by Dirk Hohndel
parent 88101e4dd3
commit 15a014105b
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
qt-mobile/qml/GpsList.qml
View File

@ -53,7 +53,7 @@ MobileComponents.Page {
}
MobileComponents.Label {
text: date
width: Math.max(parent.width / 5, paintedWidth) // helps vertical alignment throughout listview
Layout.preferredWidth: Math.max(parent.width / 5, paintedWidth)
font.pointSize: subsurfaceTheme.smallPointSize
}
MobileComponents.Label {
@ -63,7 +63,7 @@ MobileComponents.Page {
}
MobileComponents.Label {
text: name
width: Math.max(parent.width / 5, paintedWidth) // helps vertical alignment throughout listview
Layout.preferredWidth: Math.max(parent.width / 5, paintedWidth)
font.pointSize: subsurfaceTheme.smallPointSize
}
MobileComponents.Label {

2
qt-mobile/qml/Preferences.qml
View File

@ -57,7 +57,7 @@ GridLayout {
Item { width: MobileComponents.Units.gridUnit; height: width }
Item {
height: saveButton.height
width: saveButton.width
Layout.preferredWidth: saveButton.width
Button {
id: saveButton
text: "Save"