From eb12a0aa20e6c9e2e74beafcb5c60cda2d88dfee Mon Sep 17 00:00:00 2001 From: Jef Driesen Date: Fri, 28 Mar 2014 10:25:07 +0100 Subject: [PATCH] Remove an infinite loop. If an unknown type byte is encountered, the offset isn't incremented, resulting in an infinite loop. We now return an error instead. --- src/diverite_nitekq_parser.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/diverite_nitekq_parser.c b/src/diverite_nitekq_parser.c index 0bed7c5..deba81b 100644 --- a/src/diverite_nitekq_parser.c +++ b/src/diverite_nitekq_parser.c @@ -252,8 +252,8 @@ diverite_nitekq_parser_samples_foreach (dc_parser_t *abstract, dc_sample_callbac offset += 7; break; default: - INFO (abstract->context, "Unknown type %02x", type); - break; + ERROR (abstract->context, "Unknown type %02x", type); + return DC_STATUS_DATAFORMAT; } } else if (type == 2 || type == 3) { dc_sample_value_t sample = {0};