FlapJackApps/libdivecomputer
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Prevent an infinite loop.

Browse Source 
When the number of parameters is zero, there are no sample values, and
the offset variable is never increased. The result is an infinite loop.
In practice this shouldn't happen because there should always be at
least one sample value (e.g. depth). But if a new data format is
available, which is not yet supported by the parser, we might be trying
to interpret the wrong byte.
This commit is contained in:
Jef Driesen 2013-04-18 08:11:51 +02:00
parent 3ce237eee4
commit 8f3eb48bfb
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/suunto_d9_parser.c
View File

@ -314,7 +314,7 @@ suunto_d9_parser_samples_foreach (dc_parser_t *abstract, dc_sample_callback_t ca
// Number of parameters in the configuration data.
unsigned int nparams = data[config];
if (nparams > MAXPARAMS)
if (nparams == 0 || nparams > MAXPARAMS)
return DC_STATUS_DATAFORMAT;
// Available divisor values.