FlapJackApps/libdivecomputer
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix -Wcast-qual compiler warning

Browse Source 
String literals have the type 'char[N]' by default. Allthough they are
not really 'const', modifying a string literal is undefined behaviour.
Therefore, to avoid mistakes, libdivecomputer uses the -Wwrite-strings
compiler option to change the default type to 'const char[N]'.

The cast that triggers the -Wcast-qual warning can be avoided by using a
character array instead of string literal.
This commit is contained in:
Jef Driesen 2020-07-18 00:26:42 +02:00
parent 548fce69f8
commit 7c9726da64
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
examples/dctool.c
View File

@ -240,7 +240,8 @@ main (int argc, char *argv[])
} }
// Translate the help option into a command. // Translate the help option into a command.
char *argv_help[] = {(char *) "help", NULL, NULL}; char helpcmd[] = "help";
char *argv_help[] = {helpcmd, NULL, NULL};
if (help || argv[0] == NULL) { if (help || argv[0] == NULL) {
if (argv[0]) { if (argv[0]) {
argv_help[1] = argv[0]; argv_help[1] = argv[0];