FlapJackApps/libdivecomputer
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Do not detect the first package by means of the number of bytes.

Browse Source 
If the first package was a null package and the transfer was not 
aborted, it does not work properly.
This commit is contained in:
Jef Driesen 2007-12-03 13:54:21 +00:00
parent b9a43e3157
commit 4d4b0f141f
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
suunto_vyper.c
View File

@ -412,7 +412,7 @@ suunto_vyper_read_dive (vyper *device, unsigned char data[], unsigned int size,
// of maximum $SUUNTO_VYPER_PACKET_SIZE bytes. // of maximum $SUUNTO_VYPER_PACKET_SIZE bytes.
unsigned int nbytes = 0; unsigned int nbytes = 0;
for (;;) { for (unsigned int npackages = 0;; ++npackages) {
// Initial checksum value. // Initial checksum value.
unsigned char ccrc = 0x00; unsigned char ccrc = 0x00;
@ -427,10 +427,9 @@ suunto_vyper_read_dive (vyper *device, unsigned char data[], unsigned int size,
// because there is always a small chance that more data will // because there is always a small chance that more data will
// arrive later (especially with a short timeout). But I'm not // arrive later (especially with a short timeout). But I'm not
// aware of a better method to detect the end of the transmission. // aware of a better method to detect the end of the transmission.
// Only for the very first package, we can be sure there was // Only for the very first package, we can be sure there was
// an error, because it makes no sense to end the transmission // an error, because the DC always sends at least one package.
// if no data was received so far. if (rc == 0 && npackages != 0)
if (rc == 0 && nbytes != 0)
break; break;
WARNING ("Unexpected answer start byte(s)."); WARNING ("Unexpected answer start byte(s).");
return EXITCODE (rc, 2); return EXITCODE (rc, 2);