FlapJackApps/libdivecomputer
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Return a more appropriate error code.

Browse Source 
The DC_STATUS_IO code is intended for reporting low-level I/O errors.
That's not the case here, and there are more appropriate error codes
available.
This commit is contained in:
Jef Driesen 2016-01-07 22:02:12 +01:00
parent ff29d218bb
commit 0afa60bd97
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/hw_ostc3.c
View File

@ -385,7 +385,7 @@ hw_ostc3_device_init_service (hw_ostc3_device_t *device)
output[2] != 0xCD || output[3] != 0xEF ||
output[4] != S_READY) {
ERROR (context, "Failed to verify echo.");
return DC_STATUS_IO;
return DC_STATUS_PROTOCOL;
}
device->state = SERVICE;
@ -1011,7 +1011,7 @@ hw_ostc3_firmware_readfile (hw_ostc3_firmware_t *firmware, dc_context_t *context
if (firmware->checksum != hw_ostc3_firmware_checksum (firmware)) {
ERROR (context, "Failed to verify file checksum.");
return DC_STATUS_IO;
return DC_STATUS_DATAFORMAT;
}
return DC_STATUS_SUCCESS;