FlapJackApps/libdivecomputer
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Abort with an error if the buffer is too small

Browse Source 
Silently truncating the data packet if the buffer is too small will
result in a corrupt data stream.
This commit is contained in:
Jef Driesen 2017-06-20 21:25:36 +02:00
parent eae071c97d
commit 06259fed19
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/uwatec_g2.c
View File

@ -85,8 +85,8 @@ receive_data (uwatec_g2_device_t *device, unsigned char *data, unsigned int size
} }
HEXDUMP (device->base.context, DC_LOGLEVEL_DEBUG, "rcv", buf + 1, len); HEXDUMP (device->base.context, DC_LOGLEVEL_DEBUG, "rcv", buf + 1, len);
if (len > size) { if (len > size) {
ERROR (device->base.context, "receive result buffer too small - truncating"); ERROR (device->base.context, "receive result buffer too small");
len = size; return DC_STATUS_PROTOCOL;
} }
memcpy(data, buf + 1, len); memcpy(data, buf + 1, len);
size -= len; size -= len;