The Mares backend used to send the commands by splitting them up into the two-byte command and the "rest", while waiting for the ACK byte (0xAA) to come in between the two parts. That seems to work fine for the serial side, but the the BLE packets, it seems to cause too much of a delay between the command bytes and the argument bytes, and the end result is that the Mares doesn't actually act on the argument bytes at all, and just sends an EOF reply (0xEA). The Mares app itself does seem to send them as two packets, but apparently without actually waiting in between, avoiding the issue. Let's just send the command as a single write, which makes at least my loaner Mares Quad Air with the BlueLink Pro dongle happy. We may need to revisit the details of this based on feedback. But it should speed up downloading too, by avoiding the roundtrip wait for the ACK byte. This affects all the computers in the Mares Icon HD family: Matrix, Smart, Smart Apnea, Icon HD, Icon HD Net Ready, Puck Pro, Nemo Wide 2, Puck 2, Quad Air, Smart Air and Quad. Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Overview ======== Libdivecomputer is a cross-platform and open source library for communication with dive computers from various manufacturers. The official web site is: http://www.libdivecomputer.org/ The sourceforge project page is: http://sourceforge.net/projects/libdivecomputer/ Installation ============ On UNIX-like systems (including Linux, Mac OS X, MinGW), use the autotools based build system. Run the following commands from the top directory (containing this file) to configure, build and install the library and utilities: $ ./configure $ make $ make install If you downloaded the libdivecomputer source code directly from the git source code repository, then you need to create the configure script as the first step: $ autoreconf --install To uninstall libdivecomputer again, run: $ make uninstall Support ======= Please send bug reports, feedback or questions to the mailing list: http://libdivecomputer.org/cgi-bin/mailman/listinfo/devel or contact me directly: jef@libdivecomputer.org License ======= Libdivecomputer is free software, released under the terms of the GNU Lesser General Public License (LGPL). You can find a copy of the license in the file COPYING.
Description
Languages
C
98.3%
M4
1.2%
Makefile
0.5%