The garmin FIT file parser verified that a string entry fit in the field size, but it turns out that the check is wrong: a FIT file string field is not necessarily NUL-terminated at all, and it's ok to have a string that fills the entire field. We never actually then use the string length we just checked, so with the checks being bogus, all of this code just goes away. But let's update the debug printout to follow these rules. This makes parsing the example FIT file that Cédric sent us work just fine (at least superficially, in that I don't see anything obviously wrong with the result: I don't actually know what Cédric's dive was supposed to look like to verify). Reported-by: Cédric BAREYT <bareytcedric@gmail.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Overview ======== Libdivecomputer is a cross-platform and open source library for communication with dive computers from various manufacturers. The official web site is: http://www.libdivecomputer.org/ The sourceforge project page is: http://sourceforge.net/projects/libdivecomputer/ Installation ============ On UNIX-like systems (including Linux, Mac OS X, MinGW), use the autotools based build system. Run the following commands from the top directory (containing this file) to configure, build and install the library and utilities: $ ./configure $ make $ make install If you downloaded the libdivecomputer source code directly from the git source code repository, then you need to create the configure script as the first step: $ autoreconf --install To uninstall libdivecomputer again, run: $ make uninstall Support ======= Please send bug reports, feedback or questions to the mailing list: http://libdivecomputer.org/cgi-bin/mailman/listinfo/devel or contact me directly: jef@libdivecomputer.org License ======= Libdivecomputer is free software, released under the terms of the GNU Lesser General Public License (LGPL). You can find a copy of the license in the file COPYING.
Description
Languages
C
98.3%
M4
1.2%
Makefile
0.5%