FlapJackApps/libdc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Prevent buffer overrun

Browse Source 
When compiled with older Microsoft libraries, the unsafe implemention of
snprintf results in non-null terminated strings, causing numerous subsequent
issues. This fix just enlarges the used buffer to accommdate longer strings.
A more complete solution would include the use more recent Microsoft libraries in
the build process. The larger buffer is still need then, to prevent trucated
(but proper null terminated) strings.

ref: https://github.com/Subsurface-divelog/subsurface/issues/301

Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
This commit is contained in:
Jan Mulder 2017-04-12 12:45:17 +02:00
parent ca04147126
commit 84eb59c3ce
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/shearwater_predator_parser.c
View File

@ -214,7 +214,7 @@ shearwater_predator_parser_get_datetime (dc_parser_t *abstract, dc_datetime_t *d
} }
#define BUFLEN 16 #define BUFLEN 32
static dc_status_t static dc_status_t
shearwater_predator_parser_cache (shearwater_predator_parser_t *parser) shearwater_predator_parser_cache (shearwater_predator_parser_t *parser)