From 6e40a457f37640c34460b2f18a0e6bdf7019ace5 Mon Sep 17 00:00:00 2001 From: Linus Torvalds Date: Fri, 20 Aug 2021 18:20:18 -0700 Subject: [PATCH] Remove MSVC build instructions from github workflows MSVC isn't a supported target for subsurface - the Windows build is cross-compiled, not native. And MSVC is actively user-hostile, with insane errors and warnings. In particular, MSVC doesn't like "strdup()", and suggests you use the nonstandard _strdup() instead. Which is all kinds of wrong, and seems to be a "let's use strict POSIX namespace rules as an excuse to make people write less portable code". There is probably some flag to make the MSVC compiler happy with sane code, but it's easier to just disable the insanity entirely. Signed-off-by: Linus Torvalds --- .github/workflows/build.yml | 30 ------------------------------ 1 file changed, 30 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 161c2f3..8610ffc 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -122,33 +122,3 @@ jobs: with: name: ${{ github.job }}-${{ matrix.arch }} path: ${{ github.job }}-${{ matrix.arch }}.tar.gz - - msvc: - - name: Visual Studio - - runs-on: windows-latest - - strategy: - fail-fast: false - matrix: - platform: [x86, x64] - - env: - CONFIGURATION: Release - - steps: - - uses: actions/checkout@v2 - - uses: msys2/setup-msys2@v2 - with: - install: autoconf automake libtool pkg-config make gcc - - run: | - autoreconf --install --force - ./configure --prefix=/usr - shell: msys2 {0} - - uses: microsoft/setup-msbuild@v1.0.2 - - run: msbuild -m -p:Platform=${{ matrix.platform }} -p:Configuration=${{ env.CONFIGURATION }} msvc/libdivecomputer.vcxproj - - uses: actions/upload-artifact@v2 - with: - name: ${{ github.job }}-${{ matrix.platform }} - path: msvc/${{ matrix.platform }}/${{ env.CONFIGURATION }}/bin