FlapJackApps/libdc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Garmin Descent: make sure to open FIT file with O_BINARY if it exists

Browse Source 
Primoz seems to have problems downloading dives from the Garmin Descent,
even when the same files work fine for me.  I suspect it's some Windows
issue, and the primary suspect would be the usual CR/LF text conversion.

Using O_BINARY would seem to be the obviously correct thing to do, and
won't hurt.

Reported-by: Primoz P <primozicp@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Linus Torvalds 2018-10-05 11:49:17 -07:00
parent 5456475fd5
commit 419b0e0498
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/garmin.c
View File

@ -167,6 +167,10 @@ static int get_file_list(DIR *dir, struct file_list *files)
return DC_STATUS_SUCCESS;
}
#ifndef O_BINARY
#define O_BINARY 0
#endif
static dc_status_t
read_file(char *pathname, int pathlen, const char *name, dc_buffer_t *file)
{
@ -174,7 +178,7 @@ read_file(char *pathname, int pathlen, const char *name, dc_buffer_t *file)
pathname[pathlen] = '/';
memcpy(pathname+pathlen+1, name, FIT_NAME_SIZE);
fd = open(pathname, O_RDONLY);
fd = open(pathname, O_RDONLY | O_BINARY);
if (fd < 0)
return DC_STATUS_IO;