FlapJackApps/libdc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix a potential buffer overflow

Browse Source 
Check whether there is space available for a complete sample, and not
just a single byte!
This commit is contained in:
Jef Driesen 2018-10-12 09:42:26 +02:00
parent c622998fb1
commit 0b2959d8c7
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/shearwater_predator_parser.c
View File

@ -264,7 +264,7 @@ shearwater_predator_parser_cache (shearwater_predator_parser_t *parser)
unsigned int offset = headersize;
unsigned int length = size - footersize;
while (offset < length) {
while (offset + parser->samplesize <= length) {
// Ignore empty samples.
if (array_isequal (data + offset, parser->samplesize, 0x00)) {
offset += parser->samplesize;
@ -440,7 +440,7 @@ shearwater_predator_parser_samples_foreach (dc_parser_t *abstract, dc_sample_cal
unsigned int time = 0;
unsigned int offset = parser->headersize;
unsigned int length = size - parser->footersize;
while (offset < length) {
while (offset + parser->samplesize <= length) {
dc_sample_value_t sample = {0};
// Ignore empty samples.